Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor packaging #1849

Merged
merged 60 commits into from
Jun 13, 2019
Merged

Refactor packaging #1849

merged 60 commits into from
Jun 13, 2019

Conversation

fealebenpae
Copy link
Member

@fealebenpae fealebenpae commented Apr 13, 2019

Fixes #1860
Fixes #1758

# Conflicts:
#	Platform.PCL/Realm.Sync.PCL/SessionPCL.cs
@fealebenpae fealebenpae self-assigned this Apr 13, 2019
@fealebenpae fealebenpae force-pushed the yg/realm-4.0 branch 6 times, most recently from 7539b94 to c784175 Compare April 13, 2019 16:35
@listepo
Copy link

listepo commented Apr 14, 2019

@fealebenpae maybe it makes sense to replace Jenkins with Azure Pipelines?

@nirinchev
Copy link
Member

Thank you for the suggestion, but the entire Realm organization relies on Jenkins for CI and we do have all the build agents provisioned and shared between different projects. It would be an unreasonable added cost to build just the .NET SDK on Azure rather than reuse the infrastructure we already have.

Do you see some particularly appealing aspect of Azure Pipelines that I'm missing and would justify the additional time and cost to migrate to?

@listepo
Copy link

listepo commented Apr 14, 2019

@nirinchev ready infrastructure is a distinct advantage. But now I see two advantages:

  1. Free for open source projects.
  2. The ability of the community to see what problems there are in build and fix them.

About the cost of time is difficult to say. Since I just started learning Azure Pipelines.

@fealebenpae fealebenpae force-pushed the yg/realm-4.0 branch 7 times, most recently from 62de80f to b2cafc3 Compare April 15, 2019 20:42
nirinchev and others added 6 commits May 13, 2019 12:51
* Add support for subscription updating and expiration

* Changelog
* Add support for subscription inclusions

* Changelog
* Don't execute weaver multiple times

* Add test
@fealebenpae fealebenpae force-pushed the yg/realm-4.0 branch 2 times, most recently from 606d7a2 to 98a5e55 Compare May 16, 2019 17:12
@nirinchev nirinchev self-requested a review May 21, 2019 08:59
@nirinchev nirinchev marked this pull request as ready for review June 6, 2019 09:43
* Rework permissions to use the http API

* Fix the access level serialization

* More tests and fixes

* Update ROS version

* Run tests on windows-02
@nirinchev nirinchev merged commit 80118ad into master Jun 13, 2019
@nirinchev nirinchev deleted the yg/realm-4.0 branch July 10, 2019 14:23
nirinchev added a commit that referenced this pull request Jul 10, 2019
* master: (89 commits)
  Prepare for 4.0.1 (#1876)
  Fix iOS device builds (#1875)
  Prepare for 4.0.0 (#1868)
  Refactor packaging (#1849)
  Update CHANGELOG.md (#1828)
  Add session.stop/start methods (#1839)
  Prepare for 3.4.0 (#1826)
  Ensure GetInstanceAsync works with QBS config (#1827)
  Add ability to define custom log function (#1824)
  Add support for user agents (#1819)
  Bump Sync to 3.10.1 (#1772)
  Update ISSUE_TEMPLATE.md
  Release 3.3.0 (#1808)
  Expose SyncConfiguration.OnProgress (#1807)
  Throw an error when trying to call async subscription methods on background threads (#1783)
  Update CHANGELOG.md (#1777)
  Prepare for 3.2.1 (#1775)
  Fix subscription state size (#1774)
  Release 3.2.0 (#1769)
  Add ShouldCompactOnLaunch to the PCL RealmConfig (#1768)
  ...

# Conflicts:
#	Platform.PCL/Realm.PCL/Extensions/CollectionNotificationsExtensionsPCL.cs
#	Tests/Tests.Shared/CollectionTests.cs
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants