Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure GetInstanceAsync works with QBS config #1827

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Ensure GetInstanceAsync works with QBS config #1827

merged 3 commits into from
Jan 9, 2019

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jan 9, 2019 •
edited
Loading

Description

Fixes #1814

TODO

  • Changelog entry
  • Tests (if applicable)

@nirinchev nirinchev requested a review from fealebenpae January 9, 2019 15:22
@nirinchev nirinchev self-assigned this Jan 9, 2019
@nirinchev nirinchev added the T-Bug label Jan 9, 2019
@nirinchev nirinchev merged commit 8b18244 into master Jan 9, 2019
@nirinchev nirinchev deleted the ni/qbs-async-open branch January 9, 2019 16:16
nirinchev added a commit that referenced this pull request Jul 10, 2019
@nirinchev
Merge branch 'master' into ni/queryable-list
ee7db5d 
* master: (89 commits)
  Prepare for 4.0.1 (#1876)
  Fix iOS device builds (#1875)
  Prepare for 4.0.0 (#1868)
  Refactor packaging (#1849)
  Update CHANGELOG.md (#1828)
  Add session.stop/start methods (#1839)
  Prepare for 3.4.0 (#1826)
  Ensure GetInstanceAsync works with QBS config (#1827)
  Add ability to define custom log function (#1824)
  Add support for user agents (#1819)
  Bump Sync to 3.10.1 (#1772)
  Update ISSUE_TEMPLATE.md
  Release 3.3.0 (#1808)
  Expose SyncConfiguration.OnProgress (#1807)
  Throw an error when trying to call async subscription methods on background threads (#1783)
  Update CHANGELOG.md (#1777)
  Prepare for 3.2.1 (#1775)
  Fix subscription state size (#1774)
  Release 3.2.0 (#1769)
  Add ShouldCompactOnLaunch to the PCL RealmConfig (#1768)
  ...

# Conflicts:
#	Platform.PCL/Realm.PCL/Extensions/CollectionNotificationsExtensionsPCL.cs
#	Tests/Tests.Shared/CollectionTests.cs
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgeerling mgeerling mgeerling approved these changes

@fealebenpae fealebenpae Awaiting requested review from fealebenpae

Assignees

@nirinchev nirinchev

Labels
T-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirinchev @mgeerling