Add support for user agents #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey - looks like you forgot to add a T:* label - could you please add one? |
fealebenpae
approved these changes
Jan 3, 2019
| internal SyncConfigurationBase(Uri serverUri, User user = null, string optionalPath = null) | ||
| { | ||
| RealmPCLHelpers.ThrowProxyShouldNeverBeUsed(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets a value indicating how detailed the sync client's logs will be. | ||
| /// Configures various parameters of the sync . |
| @@ -108,12 +142,29 @@ internal SyncConfigurationBase(Uri serverUri, User user = null, string optionalP | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets a value indicating how detailed the sync client's logs will be. | |||
| /// Configures various parameters of the sync . | |||
| internal static string GetSDKUserAgent() | ||
| { | ||
| var version = typeof(SyncConfigurationBase).GetTypeInfo().Assembly.GetName().Version; | ||
| return $"RealmNet/{version} ({RuntimeInformation.FrameworkDescription})"; |
nirinchev
force-pushed
the
ni/user-agent
branch
2 times, most recently
from
7ed09da to
0eb21b4
Compare
nirinchev
force-pushed
the
ni/user-agent
branch
from
0eb21b4 to
e26a8af
Compare
nirinchev
added a commit
that referenced
this pull request
Jul 10, 2019
* master: (89 commits) Prepare for 4.0.1 (#1876) Fix iOS device builds (#1875) Prepare for 4.0.0 (#1868) Refactor packaging (#1849) Update CHANGELOG.md (#1828) Add session.stop/start methods (#1839) Prepare for 3.4.0 (#1826) Ensure GetInstanceAsync works with QBS config (#1827) Add ability to define custom log function (#1824) Add support for user agents (#1819) Bump Sync to 3.10.1 (#1772) Update ISSUE_TEMPLATE.md Release 3.3.0 (#1808) Expose SyncConfiguration.OnProgress (#1807) Throw an error when trying to call async subscription methods on background threads (#1783) Update CHANGELOG.md (#1777) Prepare for 3.2.1 (#1775) Fix subscription state size (#1774) Release 3.2.0 (#1769) Add ShouldCompactOnLaunch to the PCL RealmConfig (#1768) ... # Conflicts: # Platform.PCL/Realm.PCL/Extensions/CollectionNotificationsExtensionsPCL.cs # Tests/Tests.Shared/CollectionTests.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #1772 - rebase after merging it.
Fixes #1809
Here's example logs in ROS:
from iOS simulator
from .NET Core running on macOS
MergeByPKTestsis the custom user agent specified by the user..NET doesn't have an automatic way of detecting the app name because some of the platforms we support don't have a concept of an app name - e.g. .NET Core and Windows apps, so it's up to the user to set the
UserAgentto the app name/version.TODO