Skip to content

Conversation

@saikishor
Copy link
Member

We are using a wrong logger in async components

@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.56%. Comparing base (03372e0) to head (63646c0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2860      +/-   ##
==========================================
- Coverage   89.57%   89.56%   -0.02%     
==========================================
  Files         152      152              
  Lines       18087    18087              
  Branches     1470     1470              
==========================================
- Hits        16201    16199       -2     
- Misses       1297     1301       +4     
+ Partials      589      587       -2     
Flag Coverage Δ
unittests 89.56% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ardware_interface/hardware_component_interface.hpp 77.85% <100.00%> (-0.16%) ⬇️
hardware_interface/src/resource_manager.cpp 78.16% <100.00%> (-0.06%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Juliaj Juliaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saikishor
Copy link
Member Author

Yesss

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification, LGTM

@saikishor saikishor merged commit 38124b7 into ros-controls:master Nov 25, 2025
18 of 19 checks passed
@saikishor saikishor deleted the fix/logger/async_thread branch November 25, 2025 22:05
mergify bot pushed a commit that referenced this pull request Nov 25, 2025
mergify bot pushed a commit that referenced this pull request Nov 25, 2025
saikishor added a commit that referenced this pull request Nov 25, 2025
)

(cherry picked from commit 38124b7)

Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
saikishor added a commit that referenced this pull request Nov 25, 2025
)

(cherry picked from commit 38124b7)

Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants