-
Notifications
You must be signed in to change notification settings - Fork 386
Use proper hardware component logger for async components #2860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper hardware component logger for async components #2860
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2860 +/- ##
==========================================
- Coverage 89.57% 89.56% -0.02%
==========================================
Files 152 152
Lines 18087 18087
Branches 1470 1470
==========================================
- Hits 16201 16199 -2
- Misses 1297 1301 +4
+ Partials 589 587 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hardware_interface/include/hardware_interface/hardware_component_interface.hpp
Show resolved
Hide resolved
Juliaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
hardware_interface/include/hardware_interface/hardware_component_interface.hpp
Show resolved
Hide resolved
|
Yesss |
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarification, LGTM
(cherry picked from commit 38124b7)
(cherry picked from commit 38124b7)
We are using a wrong logger in async components