Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset PID controllers on activation and add save_iterm parameter #1507

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

christophfroehlich
Copy link
Contributor

Since ros-controls/control_toolbox#180 there is a parameter to control the behavior of retention of the integral term after reset.

Actually, we only have reset in on_configure here. I added the reset to on_activate() and documented the parameter in the GPL yaml.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.20%. Comparing base (af572aa) to head (fff4e8a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1507   +/-   ##
=======================================
  Coverage   84.19%   84.20%           
=======================================
  Files         123      123           
  Lines       11321    11324    +3     
  Branches      955      957    +2     
=======================================
+ Hits         9532     9535    +3     
+ Misses       1474     1473    -1     
- Partials      315      316    +1     
Flag Coverage Δ
unittests 84.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pid_controller/src/pid_controller.cpp 68.69% <100.00%> (+0.27%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant