Add tf_frame_prefix parameters to mecanum_drive_controller #1680
+273
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Maverobot,
VX792,
aprotyas,
bmagyar,
christophfroehlich,
mamueluth and
rosterloh
bmagyar
previously approved these changes
Jun 5, 2025
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
The changes are fine for me, I'm just opening the discussion if we should move this to a shared place?
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
10 tasks
bmagyar
approved these changes
Jun 7, 2025
Member
|
@bmagyar @saikishor shall we backport this to jazzy/humble? Backports #1807 and #1806 fail otherwise. |
Member
Sure, we can do it for Jazzy. If it's straight forward for Humble, let's do that as well. |
christophfroehlich
added
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2025
(cherry picked from commit 97dd175) # Conflicts: # mecanum_drive_controller/src/mecanum_drive_controller.yaml # mecanum_drive_controller/test/test_mecanum_drive_controller.hpp
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2025
(cherry picked from commit 97dd175)
This was referenced Jul 7, 2025
Member
No it's not, I closed the backport and removed the respective tests in #1806 |
Member
|
Thank you @christophfroehlich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focuses one of the points described here: #1676
Pretty much copied and adapted form diff drive controller. I've tested it on real robot and it worked fine