Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 7, 2025

During recent testing I noticed that the pose covariance matrix was not being populated in the mecanum drive controller. This PR is to populate the covariance matrix in the message using the coordinating parameters in the same way that the twist covariance matrix is populated.

Once this is merged I do want to get it backported, I'm not certain what the process is for that.


This is an automatic backport of pull request #1772 done by Mergify.

@mergify mergify bot added the conflicts label Jul 7, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Jul 7, 2025

Cherry-pick of 922e49b has failed:

On branch mergify/bp/jazzy/pr-1772
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 922e49b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   mecanum_drive_controller/src/mecanum_drive_controller.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   mecanum_drive_controller/test/mecanum_drive_controller_params.yaml
	both modified:   mecanum_drive_controller/test/test_mecanum_drive_controller.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify
Copy link
Contributor Author

mergify bot commented Jul 7, 2025

This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich @saikishor?

@christophfroehlich christophfroehlich force-pushed the mergify/bp/jazzy/pr-1772 branch from af581c1 to 28c57ea Compare July 7, 2025 10:27
@christophfroehlich christophfroehlich marked this pull request as ready for review July 7, 2025 10:27
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (e88a52a) to head (28c57ea).
Report is 1 commits behind head on jazzy.

Additional details and impacted files
@@           Coverage Diff           @@
##            jazzy    #1807   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files         127      127           
  Lines       12268    12273    +5     
  Branches     1041     1041           
=======================================
+ Hits        10434    10439    +5     
  Misses       1497     1497           
  Partials      337      337           
Flag Coverage Δ
unittests 85.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._drive_controller/src/mecanum_drive_controller.cpp 91.08% <100.00%> (+0.03%) ⬆️
..._controller/test/test_mecanum_drive_controller.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 6b5123f into jazzy Jul 7, 2025
15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-1772 branch July 7, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants