Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix broken links #554

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

christophfroehlich
Copy link
Contributor

I realized that I used wrong relative pahts in the links with #552. Furthermore, links to .rst files does not make sense because sphinx does not replace them with html links?! I tried it with the :ref: in my local sphinx installation, at least here it works. Or are there other ways to make proper links?

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I know of and sphinx keeps disappointing us

@bmagyar bmagyar merged commit b70a8d0 into ros-controls:master Mar 30, 2023
@christophfroehlich christophfroehlich deleted the fix_broken_links branch March 30, 2023 08:28
destogl added a commit to StoglRobotics-forks/ros2_controllers that referenced this pull request Apr 6, 2023
commit 5595714ca3632b0cb437163363b4204a66a32e3c
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Tue Mar 21 12:59:16 2023 -0700

    Add a reliable reference topic as well

commit ed915756a0ff5cb8abe9a0f9cdf69982581ce16f
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Tue Mar 21 10:36:56 2023 -0700

    Fix compiler warning

commit 1985db1490fd5588cacfa90086ad624f6aff93b5
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Tue Mar 21 10:22:00 2023 -0700

    Simplify setting of "has limits" for a particular limit

commit 3e3ef86d3796c3ab3c5afd908b5f2c54e39ee31b
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Mon Mar 20 12:57:01 2023 -0700

    Fix service for setting joint limits in Cartesian trajectory generator

commit 7df931cef8b10239da3784aba44e774aa860cceb
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Sun Mar 19 14:04:18 2023 -0700

    Remove position mode logic and service for setting position mode

commit 33f4d5d0e1c2b7d503a99587fbc7a960eabab3e8
Author: Denis Štogl <denis@stoglrobotics.de>
Date:   Thu Dec 22 09:50:23 2022 +0100

    Added Cartesian Trajectory Generator.

commit ccc4ab3
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Sun Apr 2 08:56:45 2023 +0100

    3.4.0

commit 05011b4
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Sun Apr 2 08:56:12 2023 +0100

    Update changelogs

commit b70a8d0
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Thu Mar 30 07:42:27 2023 +0200

    Fix broken links (ros-controls#554)

commit 03dfb84
Author: Dr. Denis <denis@stoglrobotics.de>
Date:   Tue Mar 28 20:46:14 2023 +0200

    [AdmittanceController] Addintional argument in methods of ControllerInterface (ros-controls#553)

    * [AdmittanceController] Addintional argument in methods of ControllerInterface

    * Update admittance_controller.cpp

commit eb76cd7
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Tue Mar 28 20:45:11 2023 +0200

    Update docs (ros-controls#552)

    * Add missing controllers to doc index

    * Fix wrong forward_command controller doc
destogl added a commit to SchillingRobotics/ros2_controllers that referenced this pull request May 4, 2023
commit 5595714ca3632b0cb437163363b4204a66a32e3c
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Tue Mar 21 12:59:16 2023 -0700

    Add a reliable reference topic as well

commit ed915756a0ff5cb8abe9a0f9cdf69982581ce16f
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Tue Mar 21 10:36:56 2023 -0700

    Fix compiler warning

commit 1985db1490fd5588cacfa90086ad624f6aff93b5
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Tue Mar 21 10:22:00 2023 -0700

    Simplify setting of "has limits" for a particular limit

commit 3e3ef86d3796c3ab3c5afd908b5f2c54e39ee31b
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Mon Mar 20 12:57:01 2023 -0700

    Fix service for setting joint limits in Cartesian trajectory generator

commit 7df931cef8b10239da3784aba44e774aa860cceb
Author: Bijou <bijou.abraham@technipfmc.com>
Date:   Sun Mar 19 14:04:18 2023 -0700

    Remove position mode logic and service for setting position mode

commit 33f4d5d0e1c2b7d503a99587fbc7a960eabab3e8
Author: Denis Štogl <denis@stoglrobotics.de>
Date:   Thu Dec 22 09:50:23 2022 +0100

    Added Cartesian Trajectory Generator.

commit ccc4ab3
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Sun Apr 2 08:56:45 2023 +0100

    3.4.0

commit 05011b4
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Sun Apr 2 08:56:12 2023 +0100

    Update changelogs

commit b70a8d0
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Thu Mar 30 07:42:27 2023 +0200

    Fix broken links (ros-controls#554)

commit 03dfb84
Author: Dr. Denis <denis@stoglrobotics.de>
Date:   Tue Mar 28 20:46:14 2023 +0200

    [AdmittanceController] Addintional argument in methods of ControllerInterface (ros-controls#553)

    * [AdmittanceController] Addintional argument in methods of ControllerInterface

    * Update admittance_controller.cpp

commit eb76cd7
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Tue Mar 28 20:45:11 2023 +0200

    Update docs (ros-controls#552)

    * Add missing controllers to doc index

    * Fix wrong forward_command controller doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants