Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot class TODO list #163

Closed
mhpanah opened this issue Oct 12, 2018 · 5 comments
Closed

Robot class TODO list #163

mhpanah opened this issue Oct 12, 2018 · 5 comments
Labels

Comments

@mhpanah
Copy link
Contributor

mhpanah commented Oct 12, 2018

In Robot class, getCurrentVelocity method gets odometry msg which contains both twist and pose. getCurrentPose method gets pose msg which is estimated from localization module. To make this less confusing, rename the getCurrentVelocity method to getOdometry and also rename the getCurrentPose to getCurrentEstimatedPose.

Also, the following methods needs to be implemented in Robot class:
TODO(mhpanah):

  • getFootPrint()
  • robot types and SN or ID
    
  • Add unit and integration test
    
  • Be able to configure which topic name to subscribe to
    
  • Topic names for pose and odom should should be confifured with parameters
    
  • re-enable model_.getName() from getRobotName()
    
@SteveMacenski
Copy link
Member

This class also needs timeouts, I'm looking through it for another ticket and once you recieve poses you store and then dish out after an initialization bool is set. There should be a timeout on the info in case something happens and info stops publishing you can produce a warning that you can't transform. I think TF should be involved here for this reason.

@mhpanah
Copy link
Contributor Author

mhpanah commented Oct 19, 2018

@SteveMacenski That's a good point, I agree. Initially, I was thinking to have the client to check the timestamp to see if the latest info is useful. However, it's safer to handle it in robot class in case the user is not checking the timestamp. If the latest info is not within a pre-defined threshold the robot class can throw a warning and also provide the latest info that it has.

@mhpanah mhpanah modified the milestones: October 2018, November 2018 Oct 29, 2018
@mhpanah mhpanah added the 2 - Medium Medium Priority label Nov 10, 2018
mhpanah added a commit that referenced this issue Dec 18, 2018
* renamed getCurrentVelocity and getCurrentPose

* added -V to ctest
@ghost ghost removed this from the D Turtle Release milestone Jan 29, 2019
@mkhansenbot
Copy link
Collaborator

@mhpanah - is this done?

@ghost
Copy link

ghost commented Feb 15, 2019

@mkhansen-intel No. Not done yet

@mhpanah
Copy link
Contributor Author

mhpanah commented Feb 19, 2019

@mkhansen-intel No. Not done yet

We should all brainstorm to see what functionalities we need in robot class. It's a low priority at the moment.

@ghost ghost unassigned mhpanah Mar 7, 2019
@ghost ghost added the for review label Jul 1, 2019
@ghost ghost closed this as completed Jul 1, 2019
ghost pushed a commit to logivations/navigation2 that referenced this issue Mar 7, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants