-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robot class TODO list #163
Comments
This class also needs timeouts, I'm looking through it for another ticket and once you recieve poses you store and then dish out after an initialization bool is set. There should be a timeout on the info in case something happens and info stops publishing you can produce a warning that you can't transform. I think TF should be involved here for this reason. |
@SteveMacenski That's a good point, I agree. Initially, I was thinking to have the client to check the timestamp to see if the latest info is useful. However, it's safer to handle it in robot class in case the user is not checking the timestamp. If the latest info is not within a pre-defined threshold the robot class can throw a warning and also provide the latest info that it has. |
@mhpanah - is this done? |
@mkhansen-intel No. Not done yet |
We should all brainstorm to see what functionalities we need in robot class. It's a low priority at the moment. |
In Robot class, getCurrentVelocity method gets odometry msg which contains both twist and pose. getCurrentPose method gets pose msg which is estimated from localization module. To make this less confusing, rename the getCurrentVelocity method to getOdometry and also rename the getCurrentPose to getCurrentEstimatedPose.
Also, the following methods needs to be implemented in Robot class:
TODO(mhpanah):
The text was updated successfully, but these errors were encountered: