-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] World Model refactor and new features #516
Conversation
@orduno Can you fix the linter failures before we start reviewing? |
nav2_dwb_controller/dwb_controller/include/dwb_controller/dwb_controller.hpp
Outdated
Show resolved
Hide resolved
nav2_dwb_controller/dwb_controller/include/dwb_controller/dwb_controller.hpp
Outdated
Show resolved
Hide resolved
nav2_world_model/include/nav2_world_model/world_model_client.hpp
Outdated
Show resolved
Hide resolved
@orduno Two things:
|
nav2_dwb_controller/dwb_controller/include/dwb_controller/dwb_controller.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments so far. Still working on it.
nav2_motion_primitives/include/nav2_motion_primitives/motion_primitive.hpp
Outdated
Show resolved
Hide resolved
nav2_motion_primitives/include/nav2_motion_primitives/motion_primitive.hpp
Show resolved
Hide resolved
nav2_world_model/include/nav2_world_model/rectangular_region.hpp
Outdated
Show resolved
Hide resolved
nav2_world_model/include/nav2_world_model/rectangular_region.hpp
Outdated
Show resolved
Hide resolved
nav2_world_model/include/nav2_world_model/clear_area_service_client.hpp
Outdated
Show resolved
Hide resolved
@crdelsey
I can put together some slides based on the discussion we had and share it on the working group. |
@crdelsey @SteveMacenski I think I've addressed all your feedback. Comments that have been resolved should be hidden, the ones still showing might require your response. This PR will get pushed to the If everything looks good please approve so I can proceed with merging. |
c1b4c36
to
c23710b
Compare
nav2_world_model/include/nav2_world_model/region_visualizer.hpp
Outdated
Show resolved
Hide resolved
nav2_world_model/include/nav2_world_model/region_visualizer.hpp
Outdated
Show resolved
Hide resolved
54b5094
to
b9cfd4d
Compare
Closing the PR as the main features provided have been incorporated (for example, collision checking, odom/robot centric costmap, etc.) we can continue our design discussion on #565. |
* various improvements across docs website * build issues fix
Co-authored-by: Solomon Wiznitzer <solomon.wiznitzer@resquared.com>
Basic Info
Description of contribution
nav2_world_model
. Defined an interface for specifying different world representations (WorldRepresentation
) and moved current functionality to aCostmapRepresentation
.RegionVisualizer
for displaying regions in RVIZ that get processed by the world model.Navfn
and theBackup
motion primitive to use the new world model client interface.MotionPrimitive
class calledpathIsClear()
that motion primitives can implement for checking if there is enough space for execution.Backup
so it checks if there is enough space for backing up before executing.robot_centric_costmap
with only the obstacle layer enabled and centered on the robot.Future work