Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter failures in nav2_util #71

Closed
crdelsey opened this issue Sep 7, 2018 · 2 comments · Fixed by #218
Closed

Fix linter failures in nav2_util #71

crdelsey opened this issue Sep 7, 2018 · 2 comments · Fixed by #218
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@crdelsey
Copy link
Contributor

crdelsey commented Sep 7, 2018

Test project /home/crdelsey/src/ros_dev_workspace/navigation2/build/nav2_util
Start 1: copyright
1/5 Test #1: copyright ........................***Failed 0.46 sec
Start 2: cppcheck
2/5 Test #2: cppcheck .........................***Failed 0.53 sec
Start 3: cpplint
3/5 Test #3: cpplint ..........................***Failed 1.15 sec
Start 4: lint_cmake
4/5 Test #4: lint_cmake ....................... Passed 0.46 sec
Start 5: uncrustify
5/5 Test #5: uncrustify .......................***Failed 1.06 sec
@mkhansenbot mkhansenbot added the bug Something isn't working label Sep 17, 2018
@mkhansenbot mkhansenbot added this to the September 2018 milestone Sep 17, 2018
@mkhansenbot
Copy link
Collaborator

@crdelsey - how do we reproduce these?

@crdelsey
Copy link
Contributor Author

@mkhansen-intel The easiest way to reproduce is to run colcon test. However, that won't show the specific failures. To see the details, what I do is

cd build\nav2_util
ctest -V

@crdelsey crdelsey mentioned this issue Oct 3, 2018
Closed
@mkhansenbot mkhansenbot removed this from the September 2018 milestone Oct 10, 2018
@mjeronimo mjeronimo added the help wanted Extra attention is needed label Oct 18, 2018
crdelsey pushed a commit to crdelsey/navigation2 that referenced this issue Oct 19, 2018
Fixing linter failures in nav2_util
f9da6d5 
This resolves ros-navigation#71
@crdelsey crdelsey mentioned this issue Oct 19, 2018
Merged
ghost referenced this issue in logivations/navigation2 Mar 7, 2022
@liyuanlogi @jplapp @sofiasemianchuk
AGVFM-320 Pallet pickup in odom space (#71)
53b8195 
* add GetPalletPositionFromDepthCameras.action and GetGoalFromPalletPosition.action

* set lift level action

* fix

* add missing method

* fixed naming for ports in action nodes GetGoalFromPalletPositionAction and GetPalletPositionFromDepthCamerasAction;

* add pallet_drive_obst and set LiftLevel inside pallet_pickup_without_obstacles BT

Co-authored-by: Johannes Plapp <johannes.plapp@logivations.com>
Co-authored-by: sofia.semianchuk <sofia.semianchuk@logivations.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing linter failures in nav2_util crdelsey/navigation2
3 participants
@mjeronimo @mkhansenbot @crdelsey