Fixing linter failures in nav2_util #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves ros-navigation#71
mjeronimo
reviewed
Oct 19, 2018
nav2_util/CMakeLists.txt
Outdated
| @@ -87,6 +87,10 @@ install(DIRECTORY include/ | |||
|
|
|||
| if(BUILD_TESTING) | |||
| find_package(ament_lint_auto REQUIRED) | |||
| # the following line skips the linter which checks for copyrights | |||
| # remove the line when a copyright and license is present in all source files | |||
There was a problem hiding this comment.
Same as my comment on the other PR. Wouldn't it be more accurate to say, "remove the line when all license headers are supported by the copyright checker tool and the linter tests pass," or something like that?
mjeronimo
approved these changes
Oct 20, 2018
ghost
pushed a commit
to logivations/navigation2
that referenced
this pull request
Mar 7, 2022
…s-navigation#218) * draft * Update nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/set_lift_level_action.hpp Co-authored-by: Johannes Plapp <johannes.plapp@logivations.com> * for lifting low and lowering block waiting * lift with blocking * add waiting for lifted_high when starting driving Co-authored-by: Johannes Plapp <johannes.plapp@logivations.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #71