Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated RecoveryNode to halt both children #1643

Closed
wants to merge 5 commits into from
Closed

Updated RecoveryNode to halt both children #1643

wants to merge 5 commits into from

Conversation

gimait
Copy link
Contributor

@gimait gimait commented Apr 20, 2020

Basic Info

Info Please fill out this column
Ticket(s) this addresses #1622
Primary OS tested on Ubuntu 18.04
Robotic platform tested on gazebo simulation of turtlebot

Description of contribution in a few bullet points

  • Modified the halt function on the RecoveryNode to call halt on both of its children (originally, the halt function on the base class does only call halt on its first child).

Description of documentation updates required from your changes

Future work that may be required in bullet points

gimait added 5 commits April 14, 2020 09:01
@gimait
Changed onCycleUpdate to allow preemption (ros-navigation#1622)
b881af3 
Signed-off-by: Aitor Miguel Blanco <aitormibl@gmail.com>
@gimait
Deleted unnecessary wait and corrected style (ros-navigation#1622)
f6c7160 
Signed-off-by: Aitor Miguel Blanco <aitormibl@gmail.com>
@gimait
Halt both children of RecoveryNode (ros-navigation#1622)
292105c 
Signed-off-by: Aitor Miguel Blanco <aitormibl@gmail.com>
@gimait
Merge branch 'master' of https://github.com/ros-planning/navigation2 …
93866cf 
…into wait_recovery
@gimait
Set node status to idle on halt (ros-navigation#1622)
492d80a 
Signed-off-by: Aitor Miguel Blanco <aitormibl@gmail.com>
@gimait gimait closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gimait