-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish optimal trajectory as a Path message #4640
Publish optimal trajectory as a Path message #4640
Conversation
51f66b4
to
1c56c7a
Compare
@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues. |
This also requires test coverage |
ec7c72d
to
42190da
Compare
@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues. |
42190da
to
1cd120f
Compare
@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though its not compiling (that needs to be fixed, obviously!). One more change for making it consistent with the existing code and then we're good to go
@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues. |
@alyquantillion please rebase or pull in main so that CI turns over. There was an API update in an upstream library that needs to be propagated here to build |
@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
075513e
to
676a083
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Thanks for iterating, looks perfect to me! |
Basic Info
Description of contribution in a few bullet points
nav_msgs::msg::Path
message. Needed if we want to calculate the velocity commands ourselves.Description of documentation updates required from your changes
None
Future work that may be required in bullet points
None
For Maintainers: