Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish optimal trajectory as a Path message #4640

Conversation

alyquantillion
Copy link
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses None
Primary OS tested on Ubuntu
Robotic platform tested on Gazebo simulation of a custom robot
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • I publish the optimal trajectory as a nav_msgs::msg::Path message. Needed if we want to calculate the velocity commands ourselves.

Description of documentation updates required from your changes

None


Future work that may be required in bullet points

None

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@alyquantillion alyquantillion force-pushed the feature/publish_optimal_traj_as_path_msg branch 3 times, most recently from 51f66b4 to 1c56c7a Compare August 22, 2024 10:36
Copy link
Contributor

mergify bot commented Aug 22, 2024

@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

nav2_mppi_controller/src/controller.cpp Outdated Show resolved Hide resolved
nav2_mppi_controller/src/controller.cpp Outdated Show resolved Hide resolved
nav2_mppi_controller/src/controller.cpp Outdated Show resolved Hide resolved
nav2_mppi_controller/src/controller.cpp Outdated Show resolved Hide resolved
nav2_mppi_controller/src/controller.cpp Outdated Show resolved Hide resolved
nav2_mppi_controller/src/controller.cpp Outdated Show resolved Hide resolved
nav2_mppi_controller/src/controller.cpp Outdated Show resolved Hide resolved
@SteveMacenski
Copy link
Member

This also requires test coverage

@alyquantillion alyquantillion force-pushed the feature/publish_optimal_traj_as_path_msg branch from ec7c72d to 42190da Compare August 23, 2024 12:34
Copy link
Contributor

mergify bot commented Aug 23, 2024

@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@alyquantillion alyquantillion force-pushed the feature/publish_optimal_traj_as_path_msg branch from 42190da to 1cd120f Compare August 23, 2024 12:54
Copy link
Contributor

mergify bot commented Aug 23, 2024

@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though its not compiling (that needs to be fixed, obviously!). One more change for making it consistent with the existing code and then we're good to go

nav2_mppi_controller/src/trajectory_visualizer.cpp Outdated Show resolved Hide resolved
nav2_mppi_controller/src/trajectory_visualizer.cpp Outdated Show resolved Hide resolved
nav2_mppi_controller/src/trajectory_visualizer.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Aug 24, 2024

@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@SteveMacenski
Copy link
Member

@alyquantillion please rebase or pull in main so that CI turns over. There was an API update in an upstream library that needs to be propagated here to build

Copy link
Contributor

mergify bot commented Aug 27, 2024

@alyquantillion, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
Signed-off-by: Alyssa Agnissan <alyssa.agnissan@quantillion.io>
@alyquantillion alyquantillion force-pushed the feature/publish_optimal_traj_as_path_msg branch from 075513e to 676a083 Compare August 27, 2024 09:30
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...roller/include/nav2_mppi_controller/controller.hpp 100.00% <ø> (ø)
...v2_mppi_controller/tools/trajectory_visualizer.hpp 100.00% <ø> (ø)
nav2_mppi_controller/src/controller.cpp 100.00% <100.00%> (ø)
nav2_mppi_controller/src/trajectory_visualizer.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@SteveMacenski SteveMacenski merged commit 836d37c into ros-navigation:main Aug 27, 2024
11 checks passed
@SteveMacenski
Copy link
Member

Thanks for iterating, looks perfect to me!

@alyquantillion alyquantillion deleted the feature/publish_optimal_traj_as_path_msg branch August 27, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants