Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tracking_id -> id, id -> class_id #52

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Rename tracking_id -> id, id -> class_id #52

merged 2 commits into from
Jan 7, 2021

Conversation

mintar
Copy link
Contributor

@mintar mintar commented Dec 21, 2020

No description provided.

@mintar mintar mentioned this pull request Dec 21, 2020
Closed
SteveMacenski
SteveMacenski reviewed Dec 21, 2020
View reviewed changes
msg/ObjectHypothesis.msg Show resolved Hide resolved
msg/Detection2D.msg Show resolved Hide resolved
@mintar mintar force-pushed the clarify-class-object-id branch from c914be8 to a8ccb2a Compare January 4, 2021 13:29
@mintar mintar force-pushed the clarify-class-object-id branch from a8ccb2a to 884129c Compare January 6, 2021 16:51
SteveMacenski
SteveMacenski approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kukanani are you OK with this?

@Kukanani Kukanani changed the title Rename tracking_id -> object_id, id -> class_id Rename tracking_id -> id, id -> class_id Jan 7, 2021
@Kukanani
Copy link
Collaborator

Kukanani commented Jan 7, 2021

LGTM

@Kukanani Kukanani merged commit f5b2639 into ros-perception:ros2 Jan 7, 2021
@mintar mintar deleted the clarify-class-object-id branch January 7, 2021 13:39
@2b-t 2b-t mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kukanani Kukanani Kukanani left review comments

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mintar @Kukanani @SteveMacenski