-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use random HashMap
keys on Hermit
#107387
Conversation
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
☔ The latest upstream changes (presumably #107405) made this pull request unmergeable. Please resolve the merge conflicts. |
1353291
to
fdbf109
Compare
Thanks!!! |
To save me some time, do you have a link to the hermit docs at hand? |
Here you go: https://docs.rs/hermit-abi/latest/hermit_abi/fn.read_entropy.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I just have one quick question but I'm otherwise happy to merge this.
@bors r+ rollup |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107387 (Use random `HashMap` keys on Hermit) - rust-lang#109511 (Make `EvalCtxt`'s `infcx` private) - rust-lang#109554 (Suggest ..= when someone tries to create an overflowing range) - rust-lang#109675 (Do not consider elaborated projection predicates for objects in new solver) - rust-lang#109693 (Remove ~const from alloc) - rust-lang#109700 (Lint against escape sequences in Fluent files) - rust-lang#109716 (Move `mir::Field` → `abi::FieldIdx`) - rust-lang#109726 (rustdoc: Don't strip crate module) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
414: switch to the latest nightly compiler r=stlankes a=stlankes - the latest std library use random `HashMap` keys rust-lang/rust#107387 - fix typo in the creation of OpenOption for RustyHermit rust-lang/rust#109368 Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
414: switch to the latest nightly compiler r=stlankes a=stlankes - the latest std library use random `HashMap` keys rust-lang/rust#107387 - fix typo in the creation of OpenOption for RustyHermit rust-lang/rust#109368 Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
Initializing the keys with random data provided by the libOS avoids HashDOS attacks and similar issues.
CC @stlankes