-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EvalCtxt
's infcx
private
#109511
Make EvalCtxt
's infcx
private
#109511
Conversation
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
62819ba
to
5c570aa
Compare
☔ The latest upstream changes (presumably #109517) made this pull request unmergeable. Please resolve the merge conflicts. |
5c570aa
to
2420699
Compare
2420699
to
3362143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits which you may or may not fix
after that r=me
compiler/rustc_trait_selection/src/solve/eval_ctxt/canonical.rs
Outdated
Show resolved
Hide resolved
3362143
to
a61616a
Compare
@bors r=lcnr rollup (only affects new solver) |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107387 (Use random `HashMap` keys on Hermit) - rust-lang#109511 (Make `EvalCtxt`'s `infcx` private) - rust-lang#109554 (Suggest ..= when someone tries to create an overflowing range) - rust-lang#109675 (Do not consider elaborated projection predicates for objects in new solver) - rust-lang#109693 (Remove ~const from alloc) - rust-lang#109700 (Lint against escape sequences in Fluent files) - rust-lang#109716 (Move `mir::Field` → `abi::FieldIdx`) - rust-lang#109726 (rustdoc: Don't strip crate module) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
To better protect against people doing bad things with the inner
InferCtxt
r? @lcnr