Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disqualify built-in trait impl if it seems likely to overlap in an unsound way with a blanket impl #132289

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disqualify built-in trait impl if it seems likely to overlap in an unsound way with a blanket impl #132289

wants to merge 2 commits into from
+453 −20

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Oct 28, 2024 •
edited by lcnr
Loading

cc #57893

r? lcnr

@compiler-errors
Copy link
Member Author

@bors try

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 28, 2024
@bors
Copy link
Contributor

bors commented Oct 28, 2024

⌛ Trying commit 3ee780b with merge 264a7c4...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
@bors
Auto merge of rust-lang#132289 - compiler-errors:vanquish-dyn-incompl…
264a7c4 
…eteness, r=<try>

Disqualify built-in trait impl if it seems likely to be overlap in an unsound way with a blanket impl

r? lcnr
@compiler-errors compiler-errors changed the title Disqualify built-in trait impl if it seems likely to be overlap in an unsound way with a blanket impl Disqualify built-in trait impl if it seems likely to overlap in an unsound way with a blanket impl Oct 28, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Oct 28, 2024

☀️ Try build successful - checks-actions
Build commit: 264a7c4 (264a7c4a1c917c83d13895a31231f9d93c7b67e1)

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-132289 created and queued.
🤖 Automatically detected try build 264a7c4
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment pr-132289 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@lcnr
Copy link
Contributor

lcnr commented Oct 29, 2024 •
edited
Loading

we may also want to emit a warn by default lint for all impls which disable the builtin object impl 🤔 even if that lint will mostly be unactionable 😅 potentially even regardless of whether we actually disable the impl because the trait has an associated type as adding such an impl will mean that adding an associated type will cause your trait to not be object safe anymore which is likely surprising

let's first see the crater run though

@craterbot
Copy link
Collaborator

🎉 Experiment pr-132289 is completed!
📊 22 regressed and 1 fixed (531984 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 1, 2024
@lcnr lcnr added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Nov 5, 2024
@lcnr
Copy link
Contributor

lcnr commented Nov 5, 2024

crater analysis https://hackmd.io/burOEs9MQdelPgk4frE76g

@compiler-errors
Copy link
Member Author

@bors try

@compiler-errors
Copy link
Member Author

for later:

craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-132289/retry-regressed-list.txt

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#132289 - compiler-errors:vanquish-dyn-incompl…
1a961a0 
…eteness, r=<try>

Disqualify built-in trait impl if it seems likely to overlap in an unsound way with a blanket impl

cc rust-lang#57893

r? lcnr
@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit bb80bba with merge 1a961a0...

@compiler-errors
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 264f242 with merge 4ce0d30...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#132289 - compiler-errors:vanquish-dyn-incompl…
4ce0d30 
…eteness, r=<try>

Disqualify built-in trait impl if it seems likely to overlap in an unsound way with a blanket impl

cc rust-lang#57893

r? lcnr
@bors
Copy link
Contributor

bors commented Nov 21, 2024

☀️ Try build successful - checks-actions
Build commit: 4ce0d30 (4ce0d30f2c24854a6a87cad4608888f9c18a94db)

@compiler-errors
Copy link
Member Author

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-132289/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-132289-1 created and queued.
🤖 Automatically detected try build 4ce0d30
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment pr-132289-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-132289-1 is completed!
📊 2 regressed and 0 fixed (421 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @bors @rust-log-analyzer @craterbot @lcnr @rustbot