Skip to content

Fix ptr::from_ref documentation example comment #134908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix ptr::from_ref documentation example comment #134908

merged 1 commit into from
Jan 10, 2025

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Dec 29, 2024 •
edited
Loading

The comment says that the expression involves no function call, but that was only true for the example above, the example here does contain a function call.

@rustbot label A-docs

@madsmtm
Fix ptr::from_ref documentation example comment
5966ba0 
The comment says that the expression involves no function call, but
that was only true for the example above, the example here _does_
contain a function call.
@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2024

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Dec 29, 2024
@ibraheemdev
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Collaborator

bors commented Jan 9, 2025

📌 Commit 5966ba0 has been approved by ibraheemdev

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 9, 2025

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2025
@workingjubilee workingjubilee mentioned this pull request Jan 10, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 10, 2025
Merged
@bors bors merged commit 6a40d50 into rust-lang:master Jan 10, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 10, 2025
@madsmtm madsmtm deleted the ptr-from_ref-docs branch January 10, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ibraheemdev ibraheemdev

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
4 participants
@madsmtm @rustbot @ibraheemdev @bors