Skip to content

Add Pin::as_deref_mut to 1.84 relnotes #135275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add Pin::as_deref_mut to 1.84 relnotes #135275

merged 1 commit into from
Jan 10, 2025

Conversation

coolreader18
Copy link
Contributor

Resolves #131243 - I think this got missed in the relnotes sweep or something.

@rustbot label relnotes

@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Jan 9, 2025
@rustbot rustbot mentioned this pull request Jan 9, 2025
Closed
3 tasks
@coolreader18 coolreader18 changed the title Add Pin::as_deref_mut to relnotes Add Pin::as_deref_mut to 1.84 relnotes Jan 9, 2025
@Noratrieb Noratrieb removed the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 9, 2025
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 9, 2025

I wonder why it didn't show up, maybe due to it not having been in the 1.84.0 milestone? #129424 was definitely in 1.84.0 though so this was indeed missed. Thanks :3

r? @BoxyUwU
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 9, 2025

📌 Commit 326fedf has been approved by BoxyUwU

It is now in the queue for this repository.

@rustbot rustbot assigned BoxyUwU and unassigned Mark-Simulacrum Jan 9, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2025
@traviscross traviscross mentioned this pull request Jan 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
@bors
Auto merge of rust-lang#135275 - coolreader18:pin-as_deref_mut-relnot…
1771b80 
…es, r=BoxyUwU

Add Pin::as_deref_mut to 1.84 relnotes

Resolves rust-lang#131243 - I think this got missed in the relnotes sweep or something.

`@rustbot` label relnotes
@bors
Copy link
Collaborator

bors commented Jan 9, 2025

⌛ Testing commit 326fedf with merge 1771b80...

@bors
Copy link
Collaborator

bors commented Jan 9, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 9, 2025
@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
curl: (22) The requested URL returned error: 404
curl: (22) The requested URL returned error: 404
ERROR: failed to download llvm from ci

    HELP: There could be two reasons behind this:
        1) The host triple is not supported for `download-ci-llvm`.
        2) Old builds get deleted after a certain time.
    HELP: In either case, disable `download-ci-llvm` in your config.toml:
    [llvm]
    download-ci-llvm = false
    
Build completed unsuccessfully in 0:00:22

@tgross35
Copy link
Contributor

tgross35 commented Jan 10, 2025 •
edited
Loading

@bors retry buggy CI today

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jan 10, 2025
@workingjubilee
Rollup merge of rust-lang#135275 - coolreader18:pin-as_deref_mut-reln…
c1ba22b 
…otes, r=BoxyUwU

Add Pin::as_deref_mut to 1.84 relnotes

Resolves rust-lang#131243 - I think this got missed in the relnotes sweep or something.

`@rustbot` label relnotes
@workingjubilee workingjubilee mentioned this pull request Jan 10, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 10, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2025
@bors
Auto merge of rust-lang#135319 - matthiaskrgr:rollup-un5lol6, r=matth…
67951d9 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#133088 (`-Zrandomize-layout` harder. `Foo<T> != Foo<U>`)
 - rust-lang#134619 (Improve prose around `as_slice` example of IterMut)
 - rust-lang#134855 (Add `default_field_values` entry to unstable book)
 - rust-lang#134908 (Fix `ptr::from_ref` documentation example comment)
 - rust-lang#135275 (Add Pin::as_deref_mut to 1.84 relnotes)
 - rust-lang#135294 (Make `bare-fn-no-impl-fn-ptr-99875` test less dependent on path width)
 - rust-lang#135304 (Add tests cases from review of rust-lang#132289)
 - rust-lang#135308 (Make sure to walk into nested const blocks in `RegionResolutionVisitor`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7739e28 into rust-lang:master Jan 10, 2025
6 of 7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2025
@rust-timer
Unrolled build for rust-lang#135275
f004cc8 
Rollup merge of rust-lang#135275 - coolreader18:pin-as_deref_mut-relnotes, r=BoxyUwU

Add Pin::as_deref_mut to 1.84 relnotes

Resolves rust-lang#131243 - I think this got missed in the relnotes sweep or something.

``@rustbot`` label relnotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.

Tracking issue for release notes of #86918: Tracking Issue for pin_deref_mut
8 participants
@coolreader18 @rustbot @BoxyUwU @bors @rust-log-analyzer @tgross35 @Mark-Simulacrum @Noratrieb