Rollup of 9 pull requests #135317
Closed
Rollup of 9 pull requests #135317
+832
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've removed the cryptic message about not being able to call `&mut self` methods while retaining a shared borrow of the iterator, such as `as_slice` produces. This is just normal borrowing rules and does not seem especially relevant here. I can whip up a replacement if someone thinks it has value.
The comment says that the expression involves no function call, but that was only true for the example above, the example here _does_ contain a function call.
previously field ordering was using the same seed for all instances of Foo, now we pass seed values through the layout tree so that not only the struct itself affects layout but also its fields
…kingjubilee `-Zrandomize-layout` harder. `Foo<T> != Foo<U>` Tracking issue: rust-lang#106764 Previously randomize-layout only used a deterministic shuffle based on the seed stored in an Adt's ReprOptions, meaning that `Foo<T>` and `Foo<U>` were shuffled by the same seed. This change adds a similar seed to each calculated LayoutData so that a struct can be randomized both based on the layout of its fields and its per-type seed. Primitives start with simple seed derived from some of their properties. Though some types can no longer be distinguished at that point, e.g. usize and u64 will still be treated the same.
Improve prose around `as_slice` example of IterMut I've removed the cryptic message about not being able to call `&mut self` methods while retaining a shared borrow of the iterator, such as `as_slice` produces. This is just normal borrowing rules and does not seem especially relevant here. I can whip up a replacement if someone thinks it has value.
…able-docs, r=jieyouxu Add `default_field_values` entry to unstable book Tracking issue: rust-lang#132162 RFC: https://github.com/rust-lang/rfcs/blob/master/text/3681-default-field-values.md
…eemdev Fix `ptr::from_ref` documentation example comment The comment says that the expression involves no function call, but that was only true for the example above, the example here _does_ contain a function call. `@rustbot` label A-docs
…otes, r=BoxyUwU Add Pin::as_deref_mut to 1.84 relnotes Resolves rust-lang#131243 - I think this got missed in the relnotes sweep or something. `@rustbot` label relnotes
Make `bare-fn-no-impl-fn-ptr-99875` test less dependent on path width This sets diagnostic-width to some arbitrary number. Seems to work on my machine.
…iler-errors Add tests cases from review of rust-lang#132289 Adding my comments as test-cases as suggested by `@jackh726` in rust-lang#132289 (comment)
…e-error, r=compiler-errors Cleanup `opaque_type_cycle_error` Small cleanup opportunity found while reading the code: the `label: bool` var isn't really needed since there's only one execution path that sets is to `true`. Also, tried to reduce right-ward drift. Best reviewed by hiding whitespace
…-obk Make sure to walk into nested const blocks in `RegionResolutionVisitor` Fixes rust-lang#135306 I tried auditing the rest of the visitors that called `.visit_body`, and it seems like this is the only one that was missing it. I wonder if we should modify intravisit (specifcially, that `NestedBodyFilter` stuff) to make this less likely to happen, tho... r? oli-obk
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Probably #135307, :'( darn CI being broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Zrandomize-layoutharder.Foo<T> != Foo<U>#133088 (-Zrandomize-layoutharder.Foo<T> != Foo<U>)as_sliceexample of IterMut #134619 (Improve prose aroundas_sliceexample of IterMut)default_field_valuesentry to unstable book #134855 (Adddefault_field_valuesentry to unstable book)ptr::from_refdocumentation example comment #134908 (Fixptr::from_refdocumentation example comment)bare-fn-no-impl-fn-ptr-99875test less dependent on path width #135294 (Makebare-fn-no-impl-fn-ptr-99875test less dependent on path width)opaque_type_cycle_error#135307 (Cleanupopaque_type_cycle_error)RegionResolutionVisitor#135308 (Make sure to walk into nested const blocks inRegionResolutionVisitor)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup