Rollup of 8 pull requests #29610
Merged
Rollup of 8 pull requests #29610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Nov 5, 2015
steveklabnik
commented
- Successful merges: 1.4 release notes #29416, Closes #24954 #29537, Editing Chapter 1 #29538, Mention what iterator terminators do with an empty iterator #29539, Fix #29542 #29567, Add note about HashMap::capacity's bounds #29568, Mention multiple impl blocks in TRPL #29571, Mention [T]::sort is stable in docs #29579
- Failed merges:
There was a bunch of manual fixes too... rustfmt isn't quite there yet
A line may be indented with both spaces or tabs. All leading whitespace is trimmed, even if it is mixed.
Needed for distcheck to pass and to have a working tarball.
When referring to the different shared library extensions, specify the OS explicitly.
information when constructing MIR.
module and into `hair/cx`, now that we don't have a trait defining the interface
lvalues and operands
The current readme provides critical information about gcc versions too late in the flow. r? @steveklabnik
This replaces usage of the (missing) `fatal!` macro with `panic!`.
This basically just inlines the fatal! macro from BurntSushi's [blog post](http://blog.burntsushi.net/rust-error-handling/#argument-parsing). cc @steveklabnik
…minor, r=nikomatsakis When referring to the different shared library extensions, specify the OS explicitly.
…sakis Needed for distcheck to pass and to have a working tarball.
…chton The "m" memory constraint in inline assembly is broken (generates incorrect code or triggers LLVM asserts) and should not be used. Instead, indirect memory operands should be used with "\*m", "=\*m" and "+\*m". Clang does this transparently by transforming "m" constraints into "\*m" indirect constraints, but for now just being able to use "\*m" directly is enough since asm! isn't stable. While "\*m" works fine as an input operand, "=\*m" and "+\*m" need to be specified as input operands because they take a pointer value as an input. This PR relaxes the constraint checker to allow constraints starting with "=" or "+" if the constraint string contains a "\*", which indicates an indirect operand. This (indirectly) fixes these issues: rust-lang#29382, rust-lang#16383 and rust-lang#13366. The code will need to be changed to use "\*m" instead of "m".
This is basically a more conservative recreation of rust-lang#24096.
[Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md) More highlights would be good. I intend to go through and hyperlink all the APIs still.
I did some preliminary editing work with No Starch on the first chapter of the book, and here's some of the results. We're going to want to return to this later when @brson etc's new rustup work is done, so this is mostly just a first pass. But, we agreed that having separate chapters for each of this bit of intro is a bit excessive. So let's move all of this intro stuff into one chapter. I'd appreciate a careful review of this, as there was also some confusion about some things, which resulted in me taking one huge markdown file apart and splitting it back up, as well as some editor issues, so I _think_ this looks good, but double checking things matters! /cc @aturon
Reword "Writing the logic" paragraph to prevent `unwrap` being confused for a macro (and other small changes to improve the flow of the paragraph). cc @steveklabnik
|
@bors: r+ p=100 |
|
📌 Commit 05cbfa4 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
added a commit
that referenced
this pull request
Nov 5, 2015
|
⌛ Testing commit 05cbfa4 with merge 2509948... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.