-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[futures] add a few blanket impls to std #51442
Conversation
r? @KodrAus (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/liballoc/boxed.rs
Outdated
} | ||
|
||
#[unstable(feature = "futures_api", issue = "50547")] | ||
unsafe impl<F: Future<Output = ()> + Send + 'static> UnsafePoll for Box<F> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this impl is needed anymore-- I think people should prefer to use PInBox
, as it offers the same functionality in a safer way.
Thanks for adding these! Are you planning to add the missing methods on |
r? @cramertj |
right now they exist as an extension trait in futures-core, but if there’s nothing controversial about them i can move them in |
@tinaun I think it's fine to move them in-- they don't seem particularly controversial to me (thinking of |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r+ |
📌 Commit fb507ca has been approved by |
[futures] add a few blanket impls to std these were defined in the futures crate, but with the core definitions moving to std these would need to move too.
[futures] add a few blanket impls to std these were defined in the futures crate, but with the core definitions moving to std these would need to move too.
☀️ Test successful - status-appveyor, status-travis |
these were defined in the futures crate, but with the core definitions moving to std these would need to move too.