Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[futures] add a few blanket impls to std #51442

Merged
merged 3 commits into from
Jun 11, 2018

Conversation

tinaun
Copy link
Contributor

@tinaun tinaun commented Jun 8, 2018

these were defined in the futures crate, but with the core definitions moving to std these would need to move too.

@rust-highfive
Copy link
Collaborator

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2018
@rust-highfive

This comment has been minimized.

@tinaun tinaun force-pushed the more-future-impls branch from 5e6210e to e485d61 Compare June 8, 2018 21:01
@rust-highfive

This comment has been minimized.

@tinaun tinaun force-pushed the more-future-impls branch from e485d61 to 29ebbdf Compare June 8, 2018 21:17
@rust-highfive

This comment has been minimized.

@tinaun tinaun force-pushed the more-future-impls branch from 29ebbdf to 6e5c18e Compare June 8, 2018 21:57
@rust-highfive

This comment has been minimized.

}

#[unstable(feature = "futures_api", issue = "50547")]
unsafe impl<F: Future<Output = ()> + Send + 'static> UnsafePoll for Box<F> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this impl is needed anymore-- I think people should prefer to use PInBox, as it offers the same functionality in a safer way.

@cramertj
Copy link
Member

cramertj commented Jun 8, 2018

Thanks for adding these! Are you planning to add the missing methods on Poll in a separate PR?

@cramertj
Copy link
Member

cramertj commented Jun 8, 2018

r? @cramertj

@rust-highfive rust-highfive assigned cramertj and unassigned KodrAus Jun 8, 2018
@tinaun
Copy link
Contributor Author

tinaun commented Jun 8, 2018

right now they exist as an extension trait in futures-core, but if there’s nothing controversial about them i can move them in

@cramertj
Copy link
Member

cramertj commented Jun 8, 2018

@tinaun I think it's fine to move them in-- they don't seem particularly controversial to me (thinking of map, is_ready, is_pending, map_ok, and map_err).

@rust-highfive

This comment has been minimized.

@tinaun tinaun force-pushed the more-future-impls branch from 2398a97 to fee7d55 Compare June 9, 2018 03:36
@rust-highfive

This comment has been minimized.

@tinaun tinaun force-pushed the more-future-impls branch from fee7d55 to 87d36a5 Compare June 9, 2018 04:20
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:05:15] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:15] tidy error: /checkout/src/libstd/panic.rs:330: trailing whitespace
[00:05:17] some tidy checks failed
[00:05:17] 
[00:05:17] 
[00:05:17] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:17] 
[00:05:17] 
[00:05:17] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:17] Build completed unsuccessfully in 0:01:50
[00:05:17] Build completed unsuccessfully in 0:01:50
[00:05:17] make: *** [tidy] Error 1
[00:05:17] Makefile:79: recipe for target 'tidy' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1964a21c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@tinaun tinaun force-pushed the more-future-impls branch from 87d36a5 to fb507ca Compare June 9, 2018 04:38
@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 11, 2018

📌 Commit fb507ca has been approved by cramertj

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 11, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 11, 2018
[futures] add a few blanket impls to std

these were defined in the futures crate, but with the core definitions moving to std these would need to move too.
bors added a commit that referenced this pull request Jun 11, 2018
Rollup of 4 pull requests

Successful merges:

 - #50617 (Fix extern prelude failure in rustdoc)
 - #51442 ([futures] add a few blanket impls to std)
 - #51498 (Make parse_ident public)
 - #51502 (Make parse_seq_to_end and parse_path public)

Failed merges:
@bors
Copy link
Contributor

bors commented Jun 11, 2018

⌛ Testing commit fb507ca with merge 1d4dbf4...

bors added a commit that referenced this pull request Jun 11, 2018
[futures] add a few blanket impls to std

these were defined in the futures crate, but with the core definitions moving to std these would need to move too.
@bors
Copy link
Contributor

bors commented Jun 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 1d4dbf4 to master...

@bors bors merged commit fb507ca into rust-lang:master Jun 11, 2018
@tinaun tinaun deleted the more-future-impls branch June 11, 2018 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants