Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parse_ident public #51498

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Make parse_ident public #51498

merged 1 commit into from
Jun 12, 2018

Conversation

topecongiro
Copy link
Contributor

parse_ident was made private in #51265. In rustfmt the method is used to create a custom parser for macro call.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2018
@topecongiro
Copy link
Contributor Author

r? @Mark-Simulacrum

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 11, 2018

📌 Commit ed74b0b has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2018
@mati865
Copy link
Contributor

mati865 commented Jun 11, 2018

Rocket is depending on parse_seq_to_end, other crates probably depend on yet another methods.

So to not make everything public again maybe it would be worth to create curated list of methods that should be made public. Everything else would stay as it is and broken crates will need to be fixed.

@jebrosen
Copy link
Contributor

Rocket uses at least parse_seq_to_end and parse_path, and I am currently verifying that there are no more. The plan for Rocket is to move away from libsyntax entirely, but that might take a while.

Would another pull request for Rocket's desired public methods be welcome now, or should we try to accumulate a broad list first?

@Mark-Simulacrum
Copy link
Member

Opening a PR now is fine, we'll just roll them up together.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 11, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51498 - topecongiro:pub-parse_ident, r=petr…
b610d91 
…ochenkov

Make parse_ident public

`parse_ident` was made private in rust-lang#51265. In rustfmt the method is used to create a custom parser for macro call.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 11, 2018
Closed
bors added a commit that referenced this pull request Jun 11, 2018
@bors
Auto merge of #51504 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
01fe91a 
Rollup of 4 pull requests

Successful merges:

 - #50617 (Fix extern prelude failure in rustdoc)
 - #51442 ([futures] add a few blanket impls to std)
 - #51498 (Make parse_ident public)
 - #51502 (Make parse_seq_to_end and parse_path public)

Failed merges:
PSeitz added a commit to PSeitz/rust that referenced this pull request Jun 11, 2018
@PSeitz
Make span_fatal and parse_block public
6fd9ede 
span_fatal and parse_block  were made private in rust-lang#51265. These methods are used in stainless.

Related rust-lang#51498 rust-lang#51504
@PSeitz PSeitz mentioned this pull request Jun 11, 2018
Merged
@bors
Copy link
Contributor

bors commented Jun 12, 2018

⌛ Testing commit ed74b0b with merge 1abb4ef...

bors added a commit that referenced this pull request Jun 12, 2018
@bors
Auto merge of #51498 - topecongiro:pub-parse_ident, r=petrochenkov
1abb4ef 
Make parse_ident public

`parse_ident` was made private in #51265. In rustfmt the method is used to create a custom parser for macro call.
@bors
Copy link
Contributor

bors commented Jun 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 1abb4ef to master...

@bors bors merged commit ed74b0b into rust-lang:master Jun 12, 2018
@topecongiro topecongiro deleted the pub-parse_ident branch June 12, 2018 05:56
bors added a commit that referenced this pull request Jun 12, 2018
@bors
Auto merge of #51508 - PSeitz:master, r=Mark-Simulacrum
a1aae29 
Make span_fatal and parse_block public

span_fatal and parse_block  were made private in #51265. These methods are used in stainless.

Related #51498 #51504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@topecongiro @rust-highfive @petrochenkov @bors @mati865 @jebrosen @Mark-Simulacrum