Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parse_seq_to_end and parse_path public #51502

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Make parse_seq_to_end and parse_path public #51502

merged 1 commit into from
Jun 12, 2018

Conversation

jebrosen
Copy link
Contributor

(see rwf2/Rocket#660, #51265)

Rocket currently uses parse_seq_to_end and parse_path in its codegen macros. Assuming I tested correctly, this is the minimal set of methods that are currently necessary to build Rocket again. I would be happy to add documentation of this and Rocket's other usages, if desired.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 11, 2018

📌 Commit 7e56261 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 11, 2018
…Simulacrum

Make parse_seq_to_end and parse_path public

(see rwf2/Rocket#660, rust-lang#51265)

Rocket currently uses `parse_seq_to_end` and `parse_path` in its codegen macros. Assuming I tested correctly, this is the minimal set of methods that are currently necessary to build Rocket again. I would be happy to add documentation of this and Rocket's other usages, if desired.
bors added a commit that referenced this pull request Jun 11, 2018
Rollup of 4 pull requests

Successful merges:

 - #50617 (Fix extern prelude failure in rustdoc)
 - #51442 ([futures] add a few blanket impls to std)
 - #51498 (Make parse_ident public)
 - #51502 (Make parse_seq_to_end and parse_path public)

Failed merges:
@bors
Copy link
Contributor

bors commented Jun 12, 2018

⌛ Testing commit 7e56261 with merge 9c75381f556b290cfd19932386c6065e13de81d8...

@bors
Copy link
Contributor

bors commented Jun 12, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 12, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:58:22] warning: spurious network error (2 tries remaining): curl error: Couldn't resolve host 'github.com'
[01:58:22] ; class=Net (12)
[01:59:18] warning: spurious network error (1 tries remaining): curl error: Couldn't resolve host 'github.com'
[01:59:18] ; class=Net (12)
[02:00:14] error: failed to load source for a dependency on `rand`
[02:00:14] Caused by:
[02:00:14]   Unable to update registry `https://github.com/rust-lang/crates.io-index`
[02:00:14] 
[02:00:14] Caused by:
[02:00:14] Caused by:
[02:00:14]   failed to fetch `https://github.com/rust-lang/crates.io-index`
[02:00:14] 
[02:00:14] Caused by:
[02:00:14]   curl error: Couldn't resolve host 'github.com'
[02:00:14] ; class=Net (12)
[02:00:14] 
[02:00:14] 
[02:00:14] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "generate-lockfile" "--manifest-path" "/checkout/obj/build/tmp/distcheck-src/rust-src/lib/rustlib/src/rust/src/libstd/Cargo.toml"
[02:00:14] 
[02:00:14] 
[02:00:14] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[02:00:14] Build completed unsuccessfully in 1:57:13
---
travis_time:end:0138cab2:start=1528787192782011547,finish=1528787192788334313,duration=6322766
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:10df1246
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2144bef0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:58:22] warning: spurious network error (2 tries remaining): curl error: Couldn't resolve host 'github.com'
[01:58:22] ; class=Net (12)
[01:59:18] warning: spurious network error (1 tries remaining): curl error: Couldn't resolve host 'github.com'
[01:59:18] ; class=Net (12)
[02:00:14] error: failed to load source for a dependency on `rand`
[02:00:14] Caused by:
[02:00:14]   Unable to update registry `https://github.com/rust-lang/crates.io-index`
[02:00:14] 
[02:00:14] Caused by:
[02:00:14] Caused by:
[02:00:14]   failed to fetch `https://github.com/rust-lang/crates.io-index`
[02:00:14] 
[02:00:14] Caused by:
[02:00:14]   curl error: Couldn't resolve host 'github.com'
[02:00:14] ; class=Net (12)
[02:00:14] 
[02:00:14] 
[02:00:14] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "generate-lockfile" "--manifest-path" "/checkout/obj/build/tmp/distcheck-src/rust-src/lib/rustlib/src/rust/src/libstd/Cargo.toml"
[02:00:14] 
[02:00:14] 
[02:00:14] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[02:00:14] Build completed unsuccessfully in 1:57:13
---
travis_time:end:0138cab2:start=1528787192782011547,finish=1528787192788334313,duration=6322766
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:10df1246
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2144bef0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@SergioBenitez
Copy link
Contributor

@Mark-Simulacrum Can we retry?

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 12, 2018
…Simulacrum

Make parse_seq_to_end and parse_path public

(see rwf2/Rocket#660, rust-lang#51265)

Rocket currently uses `parse_seq_to_end` and `parse_path` in its codegen macros. Assuming I tested correctly, this is the minimal set of methods that are currently necessary to build Rocket again. I would be happy to add documentation of this and Rocket's other usages, if desired.
bors added a commit that referenced this pull request Jun 12, 2018
Rollup of 3 pull requests

Successful merges:

 - #51261 (Updated RELEASES.md for 1.27.0)
 - #51502 (Make parse_seq_to_end and parse_path public)
 - #51510 (Long diagnostic for E0538)

Failed merges:
@bors bors merged commit 7e56261 into rust-lang:master Jun 12, 2018
@jebrosen jebrosen deleted the pub_parse_methods branch June 12, 2018 20:41
kennytm added a commit to kennytm/rust that referenced this pull request Jun 22, 2018
…-Simulacrum

make more libsyntax methods public

Followup for rust-lang#51502, which was sufficient only for the latest stable release of Rocket. The `master` branch uses a few more. I plan to reimplement the deleted method `parse_seq` in Rocket (see rwf2/Rocket#666), rather than resurrecting it in libsyntax.

r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants