Skip to content

Rollup of 4 pull requests #51504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Rollup of 4 pull requests #51504

wants to merge 0 commits into from

Conversation

Mark-Simulacrum
Copy link
Member

Successful merges:

Failed merges:

@rust-highfive
Copy link
Contributor

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2018
@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=5

r? @Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Jun 11, 2018

📌 Commit 8e32eb3 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2018
@bors
Copy link
Collaborator

bors commented Jun 11, 2018

⌛ Testing commit 8e32eb3 with merge 01fe91a...

bors added a commit that referenced this pull request Jun 11, 2018
@bors
Auto merge of #51504 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
01fe91a 
Rollup of 4 pull requests

Successful merges:

 - #50617 (Fix extern prelude failure in rustdoc)
 - #51442 ([futures] add a few blanket impls to std)
 - #51498 (Make parse_ident public)
 - #51502 (Make parse_seq_to_end and parse_path public)

Failed merges:
PSeitz added a commit to PSeitz/rust that referenced this pull request Jun 11, 2018
@PSeitz
Make span_fatal and parse_block public
6fd9ede 
span_fatal and parse_block  were made private in rust-lang#51265. These methods are used in stainless.

Related rust-lang#51498 rust-lang#51504
@PSeitz PSeitz mentioned this pull request Jun 11, 2018
Merged
@bors
Copy link
Collaborator

bors commented Jun 11, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2018
bors added a commit that referenced this pull request Jun 12, 2018
@bors
Auto merge of #51508 - PSeitz:master, r=Mark-Simulacrum
a1aae29 
Make span_fatal and parse_block public

span_fatal and parse_block  were made private in #51265. These methods are used in stainless.

Related #51498 #51504
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @rust-highfive @bors @Centril @aidanhs