BTreeMap: correct node size test case for choices of B #81210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
ssomers
force-pushed
the
btree_fix_node_size_test
branch
from
bb5e60a to
f1df921
Compare
Mark-Simulacrum
added
S-waiting-on-author
ssomers
force-pushed
the
btree_fix_node_size_test
branch
2 times, most recently
from
1137582 to
d00c850
Compare
|
Also stripped benchmarks that cause a stack overflow for bigger choices of B. There's little point in assessing the performance of 4 KB key-value pairs when the physical limit is below 24 KB. And yes, this is because mod node uses |
rustbot
added
S-waiting-on-review
|
@bors r+ box vs Box::new is interesting. I would not be opposed to using box fwiw, I think, but I expect that the difference is likely noise. |
|
📌 Commit d00c850 has been approved by |
bors
added
S-waiting-on-bors
Well I turned it into #81444. |
This was referenced Jan 27, 2021
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 28, 2021
…=Mark-Simulacrum BTreeMap: correct node size test case for choices of B r? ```@Mark-Simulacrum```
henryboisdequin
added a commit
to henryboisdequin/rust
that referenced
this pull request
Jan 29, 2021
…=Mark-Simulacrum BTreeMap: correct node size test case for choices of B r? ````@Mark-Simulacrum````
This was referenced Jan 29, 2021
ssomers
force-pushed
the
btree_fix_node_size_test
branch
from
d00c850 to
2070b8a
Compare
ssomers
force-pushed
the
btree_fix_node_size_test
branch
from
2070b8a to
fc67baa
Compare
ssomers
force-pushed
the
btree_fix_node_size_test
branch
from
fc67baa to
d9daedd
Compare
|
@rustbot label: -S-waiting-on-bors +S-waiting-on-review |
rustbot
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit d9daedd has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#81210 (BTreeMap: correct node size test case for choices of B) - rust-lang#82360 (config.toml parsing error improvements) - rust-lang#82428 (Update mdbook) - rust-lang#82480 (Remove `ENABLE_DOWNLOAD_RUSTC` constant) - rust-lang#82578 (Add some diagnostic items for Clippy) - rust-lang#82620 (Apply lint restrictions from renamed lints) - rust-lang#82635 (Fix typos in rustc_infer::infer::nll_relate) - rust-lang#82645 (Clarify that SyncOnceCell::set blocks.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Mark-Simulacrum