Clarify that SyncOnceCell::set blocks. #82645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading the discussion of this feature, I gained the mistaken impression that neither `set` nor `get` blocked, and thus calling `get` immediately after `set` was not guaranteed to succeed. It turns out that `set` *does* block, guaranteeing that the cell contains a value once `set` returns. This change updates the documentation to state that explicitly.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 2616960 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#81210 (BTreeMap: correct node size test case for choices of B) - rust-lang#82360 (config.toml parsing error improvements) - rust-lang#82428 (Update mdbook) - rust-lang#82480 (Remove `ENABLE_DOWNLOAD_RUSTC` constant) - rust-lang#82578 (Add some diagnostic items for Clippy) - rust-lang#82620 (Apply lint restrictions from renamed lints) - rust-lang#82635 (Fix typos in rustc_infer::infer::nll_relate) - rust-lang#82645 (Clarify that SyncOnceCell::set blocks.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the discussion of this feature, I gained the mistaken impression that neither
setnorgetblocked, and thus callinggetimmediately aftersetwas not guaranteed to succeed. It turns out thatsetdoes block, guaranteeing that the cell contains a value oncesetreturns. This change updates the documentation to state that explicitly.Happy to adjust the wording as desired.