Rollup of 8 pull requests #87269
Merged
Rollup of 8 pull requests #87269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 91c3eee, the global ARGC and ARGV no longer reference dynamically-allocated memory, so they don't need to be cleaned up.
In the command-line argument initialization code, remove the Mutex around the `ARGV` and `ARGC` variables, and simply check whether ARGV is non-null before dereferencing it. This way, if either of ARGV or ARGC is not initialized, we'll get an empty argument list. This allows simple cdylibs to avoid having `pthread_mutex_lock`/`pthread_mutex_unlock` appear in their symbol tables if they don't otherwise use threads.
Previously, we would only look at associated types in `impl` blocks.
Add --nocapture option to rustdoc Fixes rust-lang#26309. Fixes rust-lang#45724. Once this PR is merged, I'll send a PR to cargo to also pass `--nocapture` to rustdoc. cc `@jyn514` r? `@camelid`
…-headers, r=GuillaumeGomez Rustdoc accessibility: make the sidebar headers actual headers Part of rust-lang#87059 Preview it at: https://notriddle.com/notriddle-rustdoc-test/rustdoc-sidebar-header/std/index.html
Move asm! and global_asm! to core::arch Follow-up to rust-lang/stdarch#1183 . Implements the libs-api team decision from rust-lang#84019 (comment) . In order to not break nightly users, this PR also adds the newly-moved items to the prelude. However, a decision will need to be made before stabilization as to whether these items should remain in the prelude. I will file an issue for this separately. Fixes rust-lang#84019 . r? `@Amanieu`
…oshtriplett Simplify command-line argument initialization on unix Simplify Rust's command-line argument initialization code on unix: - The cleanup code isn't needed, because it was just zeroing out non-owning variables at runtime cleanup time. After 91c3eee, Rust's command-line initialization code on unix no longer allocates `CString`s and a `Vec` at startup time. - The `Mutex` isn't needed; if there's somehow a call to `args()` before argument initialization has happened, the code returns return an empty list, which we can do with a null check. With these changes, a simple cdylib that doesn't use threads avoids getting `pthread_mutex_lock`/`pthread_mutex_unlock` in its symbol table.
…otriddle Fix "item info" width Fixes rust-lang#87202. It now looks again like this:  cc `@jyn514` r? `@notriddle`
…li-obk Extend HIR-based WF checking to associated type defaults Previously, we would only look at associated types in `impl` blocks.
…omatsakis triagebot shortcut config Enable the new triagebot shortcuts as per [rust-lang#1381/triagebot](rust-lang/triagebot#1381)
…gisa Don't create references to uninitialized data in `List::from_arena` Previously `result` and `arena_slice` were references pointing to uninitialized data, which is technically UB. They may have been fine because the pointed data is `Copy` and and they were only written to, but the semantics of this aren't clearly defined yet, and since we have a sound way to do the same thing I don't think we should keep the possibly-unsound way.
|
@bors: r+ p=8 rollup=never |
|
📌 Commit 6cb69ea has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
List::from_arena#87268 (Don't create references to uninitialized data inList::from_arena)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup