Add migration handler for disabling seqno #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzang2019
reviewed
Jan 11, 2024
x/params/types/subspace.go
Outdated
| @@ -219,6 +219,7 @@ func (s Subspace) Update(ctx sdk.Context, key, value []byte) error { | |||
| // in the ParamSetPair by calling Subspace#Get. | |||
| func (s Subspace) GetParamSet(ctx sdk.Context, ps ParamSet) { | |||
| for _, pair := range ps.ParamSetPairs() { | |||
| fmt.Printf("PSUDEBUG - pairs: %s\n", pair) | |||
| "testing" | ||
| ) | ||
|
|
||
| func TestMigrate2to3(t *testing.T) { |
yzang2019
approved these changes
Jan 11, 2024
philipsu522
added a commit
that referenced
this pull request
Jan 17, 2024
## Describe your changes and provide context Add migration handler to add new disable seqno parameter to chain. Note that i verified that we already use default values so we can just set the params to default instead of maintaining authParamsV1 and V2 ## Testing performed to validate your change - unit tests - upgraded local chain, ensure that bank sends work
philipsu522
added a commit
that referenced
this pull request
Jan 17, 2024
## Describe your changes and provide context Add migration handler to add new disable seqno parameter to chain. Note that i verified that we already use default values so we can just set the params to default instead of maintaining authParamsV1 and V2 ## Testing performed to validate your change - unit tests - upgraded local chain, ensure that bank sends work
codchen
pushed a commit
that referenced
this pull request
Jan 24, 2024
## Describe your changes and provide context Add migration handler to add new disable seqno parameter to chain. Note that i verified that we already use default values so we can just set the params to default instead of maintaining authParamsV1 and V2 ## Testing performed to validate your change - unit tests - upgraded local chain, ensure that bank sends work
yzang2019
pushed a commit
that referenced
this pull request
Feb 5, 2024
## Describe your changes and provide context Add migration handler to add new disable seqno parameter to chain. Note that i verified that we already use default values so we can just set the params to default instead of maintaining authParamsV1 and V2 ## Testing performed to validate your change - unit tests - upgraded local chain, ensure that bank sends work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add migration handler to add new disable seqno parameter to chain. Note that i verified that we already use default values so we can just set the params to default instead of maintaining authParamsV1 and V2
Testing performed to validate your change