Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removing events for cachekv #396

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Revert removing events for cachekv #396

merged 1 commit into from
Jan 17, 2024

Conversation

yzang2019
Copy link
Collaborator

Describe your changes and provide context

This PR reverts the change in #353 and #391 until we have OCC fully enabled.

Testing performed to validate your change

Unit test coverage

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (66854d0) 54.79% compared to head (227e939) 54.84%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   54.79%   54.84%   +0.04%     
==========================================
  Files         622      622              
  Lines       52177    52187      +10     
==========================================
+ Hits        28591    28620      +29     
+ Misses      21502    21483      -19     
  Partials     2084     2084              
Files Coverage Δ
store/cachekv/mergeiterator.go 79.87% <100.00%> (+0.65%) ⬆️
store/cachekv/store.go 79.91% <50.00%> (-0.92%) ⬇️

... and 1 file with indirect coverage changes

@yzang2019 yzang2019 merged commit e12efbc into main Jan 17, 2024
15 checks passed
@yzang2019 yzang2019 deleted the yzang/SEI-6454 branch January 17, 2024 20:33
yzang2019 added a commit that referenced this pull request Jan 31, 2024
* main:
  [SeiDB] Fix concurrent map access (#411)
  No longer disable dynamic dep generation during ACL dependency generation (#404)
  fix(baseapp): Ensure Panic Recovery in Prepare & Process Handlers (#401)
  Revert removing events for cachekv (#396)
  Add migration handler for disabling seqno (#394)
philipsu522 added a commit that referenced this pull request Feb 1, 2024
yzang2019 added a commit that referenced this pull request Feb 1, 2024
udpatil pushed a commit that referenced this pull request Feb 1, 2024
udpatil pushed a commit that referenced this pull request Feb 1, 2024
codchen pushed a commit that referenced this pull request Feb 6, 2024
## Describe your changes and provide context
This PR reverts the change in
#353 and
#391 until we have OCC
fully enabled.

## Testing performed to validate your change
Unit test coverage
stevenlanders added a commit that referenced this pull request Feb 6, 2024
stevenlanders added a commit that referenced this pull request Feb 6, 2024
stevenlanders added a commit that referenced this pull request Feb 8, 2024
stevenlanders added a commit that referenced this pull request Feb 8, 2024
udpatil added a commit that referenced this pull request Feb 8, 2024
udpatil added a commit that referenced this pull request Feb 8, 2024
udpatil added a commit that referenced this pull request Apr 19, 2024
udpatil added a commit that referenced this pull request Apr 19, 2024
This reverts commit e12efbc.

## Describe your changes and provide context
We disable cachekv events for `v0.3.xx+` versions because those are used
in sei chain without allowing for parallelV1 concurrency due to its
incompatibility with EVM

## Testing performed to validate your change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants