-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert removing events for cachekv #396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 54.79% 54.84% +0.04%
==========================================
Files 622 622
Lines 52177 52187 +10
==========================================
+ Hits 28591 28620 +29
+ Misses 21502 21483 -19
Partials 2084 2084
|
philipsu522
approved these changes
Jan 17, 2024
udpatil
approved these changes
Jan 17, 2024
philipsu522
added a commit
that referenced
this pull request
Feb 1, 2024
This reverts commit e12efbc.
codchen
pushed a commit
that referenced
this pull request
Feb 6, 2024
stevenlanders
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit e12efbc.
stevenlanders
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit e12efbc.
stevenlanders
added a commit
that referenced
this pull request
Feb 8, 2024
This reverts commit e12efbc.
stevenlanders
added a commit
that referenced
this pull request
Feb 8, 2024
This reverts commit e12efbc.
udpatil
added a commit
that referenced
this pull request
Apr 19, 2024
This reverts commit e12efbc. ## Describe your changes and provide context We disable cachekv events for `v0.3.xx+` versions because those are used in sei chain without allowing for parallelV1 concurrency due to its incompatibility with EVM ## Testing performed to validate your change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR reverts the change in #353 and #391 until we have OCC fully enabled.
Testing performed to validate your change
Unit test coverage