No longer disable dynamic dep generation during ACL dependency generation #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 54.84% 54.81% -0.03%
==========================================
Files 622 622
Lines 52187 52203 +16
==========================================
- Hits 28620 28615 -5
- Misses 21483 21504 +21
Partials 2084 2084
|
udpatil
force-pushed
the
acl-dynamic-dep
branch
from
6d77a68 to
d45d10d
Compare
philipsu522
approved these changes
Jan 25, 2024
codchen
pushed a commit
that referenced
this pull request
Feb 6, 2024
…tion (#404) ## Describe your changes and provide context This removes the behavior of disabling a dynamic dependency generator if it returns something invalid during message dependency generation. This needs to be removed so that the state writes are consistent with synchronous execution, such that message dependency generation is a read-only path. This change won't cause correctness issues, but in the case that there is an incorrect dynamic dependency generator, it will result in wasted compute since it will try it every time instead of disabling it after the first time it was incorrect. This seems like an acceptable compromise in order to have consistency with synchronous execution. ## Testing performed to validate your change Updated unit tests, and tested this behavior on a loadtest cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This removes the behavior of disabling a dynamic dependency generator if it returns something invalid during message dependency generation. This needs to be removed so that the state writes are consistent with synchronous execution, such that message dependency generation is a read-only path. This change won't cause correctness issues, but in the case that there is an incorrect dynamic dependency generator, it will result in wasted compute since it will try it every time instead of disabling it after the first time it was incorrect. This seems like an acceptable compromise in order to have consistency with synchronous execution.
Testing performed to validate your change
Updated unit tests, and tested this behavior on a loadtest cluster