Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(baseapp): Ensure Panic Recovery in Prepare & Process Handlers #401

Merged
merged 3 commits into from
Jan 24, 2024
Merged

fix(baseapp): Ensure Panic Recovery in Prepare & Process Handlers #401

merged 3 commits into from
Jan 24, 2024

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 23, 2024 •
edited
Loading

Changelog

  • Ensure we have panic recovery handlers in PrepareProposal and ProcessProposal.

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (e12efbc) 54.84% compared to head (c3d4112) 54.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   54.84%   54.82%   -0.03%     
==========================================
  Files         622      622              
  Lines       52187    52208      +21     
==========================================
+ Hits        28620    28621       +1     
- Misses      21483    21503      +20     
  Partials     2084     2084
Files Coverage Δ
baseapp/abci.go 52.59% <0.00%> (-1.38%) ⬇️

... and 1 file with indirect coverage changes

@alexanderbez alexanderbez marked this pull request as ready for review January 23, 2024 23:46
yzang2019
yzang2019 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@yzang2019 yzang2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexanderbez alexanderbez merged commit f01454c into main Jan 24, 2024
14 of 15 checks passed
@alexanderbez alexanderbez deleted the bez/fix-process-proposal branch January 24, 2024 18:24
yzang2019 added a commit that referenced this pull request Jan 31, 2024
@yzang2019
Merge branch 'main' into HEAD
c70410a 
* main:
  [SeiDB] Fix concurrent map access (#411)
  No longer disable dynamic dep generation during ACL dependency generation (#404)
  fix(baseapp): Ensure Panic Recovery in Prepare & Process Handlers (#401)
  Revert removing events for cachekv (#396)
  Add migration handler for disabling seqno (#394)
codchen pushed a commit that referenced this pull request Feb 6, 2024
@alexanderbez @codchen
fix(baseapp): Ensure Panic Recovery in Prepare & Process Handlers (#401)
38993f6 
## Changelog

* Ensure we have panic recovery handlers in `PrepareProposal` and
`ProcessProposal`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzang2019 yzang2019 yzang2019 approved these changes

@codchen codchen Awaiting requested review from codchen

@philipsu522 philipsu522 Awaiting requested review from philipsu522

@udpatil udpatil Awaiting requested review from udpatil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderbez @yzang2019