Signed-off-by: Wenda Ni <wenni@microsoft.com>

* ARM32 bit fixes, for 64bit printf format specifier

Signed-off-by: Antony Rheneus <arheneus@marvell.com>

Signed-off-by: Shu0t1an Cheng <shuche@microsoft.com>

Buffer pool watermark design is built on a READ_AND_CLEAR polling mode at the syncd level. We observe some SAI implementation is missing the clear_stats operation support for buffer pool watermark, either simply not coded yet or having hardware limitation. In such cases, we have mismatch between the actual polling behavior and what a user perceives from FLEX_COUNTER_DB read from FLEX_COUNTER_GROUP_TABLE.

To have a consistent view, we propose per buffer pool watermark stats polling mode at the orchagent level when not all buffer pools support clear_stats operation on a switch. The situation is detected by issuing clear_stats operation at the orchagent level to probe the capability over all pools first. If this is truly the case, we then do not set "STATS_MODE" field in "FLEX_COUNTER_GROUP_TABLE:BUFFER_POOL_WATERMARK_STAT_COUNTER", but set it to the per buffer pool table "FLEX_COUNTER_TABLE:BUFFER_POOL_WATERMARK_STAT_COUNTER:oid:<buffer_pool_oid>".

make explicit failure if team kernel module is not available on the system

Signed-off-by: Guohan Lu <gulv@microsoft.com>

Signed-off-by: tengfei <tengfei@asterfusion.com>

default image is docker-sonic-vs:latest

Signed-off-by: Guohan Lu <gulv@microsoft.com>

This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

…1006)

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>

#997)

* Trap DHCPv6 packets for supporting ZTP over in-band interfaces using DHCPv6 discovery

Also increase incoming packet rate on in-band interfaces to support faster
download of large files. SONiC firmware image download over in-band can
take a lot of time if the incoming packet rate is limited to 600pps. This,
change increases it to 6000pps.

Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>

Config DB manual is being moved from Wiki to SWSS repo.
Once if this is merged, the page from Wiki will point to this config DB manual.
After that, whichever developer makes changes on config DB, are expected to make the corresponding changes in this manual.

The change includes two parts:

<1> Bring member out of default VLAN 1 upon putting port/lag in a VLAN

<2> Second part was done by @tieguoevan ( https://github.com/tieguoevan) and incorporated here to avoid test error that would follow change <1>.

Summary:
The Bridge interface needs to be up all the time. Otherwise, the command bridge vlan will fail.
Not sure it is a kernel bug, but it cause error when clear all vlan members and reconfigure it.

create a dummy interface in the Bridge to keep it up all the time

Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>

As the vxlan tunnel_id and tunnel_term_id are not created until the map entrys are added, in case of configuring the vxlan tunnel without map entry, and then it is invalid to remove it without validity checking.

Signed-off-by: sundandan <sundandan@asterfusion.com>

Signed-off-by: leo.li <leo.li@nephosinc.com>

Three PRs for adding BGP eoiu support to speed up route reconciliation in fpmsyncd

sonic-buildimage: sonic-net/sonic-buildimage#2823
sonic-swss-common: sonic-net/sonic-swss-common#273
sonic-swss: #856

Why I did it

Similar to restore_neigbors.py for neigborsyncd, start a bgp_eoiu_mark.py for bgp docker.

The script check bgp neighbor state via cli interface periodically (every 1 second)
It looks for explicit EOR and implicit EOR (keep alive after established) in the json output of show ip bgp neighbors A.B.C.D json

Once the script has collected all needed EORs, it set a EOIU flag in stateDB.

fpmsyncd could hold a few seconds (3 seconds) after getting the flag before starting routing reconciliation.

For any reason the script failed to set EOIU flag in stateDB, the current warm_restart bgp_timer will kick in later.

This approach may have a few more seconds delay compared with the FRR embedded EOIU solution, but simple and less risk.

Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>

add some CRM pytest test cases, the list is shown below for CRM test.

1.Test the mechanism for CRM threshold displaying SWSS_LOG_WARN by syslog checking.
2.Add CRM Acl Group test case.
3.Add the configuration tests of threshold and polling interval.

From: iris_hsu@edge-core.com

Check app db and state db after create vlan. => succeed
Check app db and state db after add vlan member. => succeed

Signed-off-by: Emma Lin <emma_lin@edge-core.com>

Signed-off-by: wangshengjun <wangshengjun@asterfusion.com>

…866)

* Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com>

…e. (#860)

* [VLAN] Add pytest cases to validate different use-case of tagging_mode.

Signed-off-by: Emma Lin <emma_lin@edge-core.com>

Problem: When SONiC CLI command is used to display summary of interface(s), broadcast address is always 0.0.0.0 irrespective of prefix length

Solution: When interface ip address is added using the command "ip addr add ...", we can specify the broadcast address as well. I did NOT set broadcast addr for interface with point-to-point link addresses(/31, and /127)

Signed-off-by: Vasant Patil vapatil@linkedin.com

Signed-off-by: Tony Titus ttitus@innovium.com

…tch (#1014)

Signed-off-by: Jared.Liu <Jared.Liu@nephosinc.com>

Monitor the changes in the configuration databaes and update
the corresponding rate/size for the policers

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

… to vlan. (#875)

* [vlan] Add pytest cases to validate the behavior about add LAG member to
vlan.

Signed-off-by: Emma Lin <emma_lin@edge-core.com>

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

I noticed that after swss restart in VS orchagent does not receive
PortInitDone. I looked at the comment about "g_portSet" says that:

 When this LinkSync class is
 * initialized, we check the database to see if some of the ports' host
 * interfaces are already created and remove them from this set.
However g_portSet was filled after LinkSync is initialized, so I
considered this is a bug causing orchagent does not receive PortInitDone
when portsyncd starts after host interfaces were created.

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

* Add a global scope to VNet to consider default VRF

* Add VS test to validate default scope changes

The log statement will cause segmentfault if `observerEntry->second.routeTable` is empty.

Signed-off-by: Ze Gan <ganze718@gmail.com>

…1031)

Increase the stale timer to "600" seconds so it won't be aged
out in case the test server is busy or slow

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>

…1034)

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

* Add default catch block in portsyncd
* Updated error message with the right spelling
* Update try block to throw exception of type runtime_error
* Remove additional paranthesis in throw statement

Signed-off-by: wangshengjun <wangshengjun@asterfusion.com>

Adding the table name in the log when creating/removing
the ACL rules.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Send arp request after first Vlan member port is added

* Add wait logic after Vlan member add, nbrmgr to wait for restore complete

* Address comment to pass db as a parameter and open only once

…#963)


* Add support for egress mirror action

* Move redirect out from PACKET_ACTION to
its own REDIRECT_ACTION key preserving
backwards compatibility with old schema
to be aligned with SAI data types

* Query ACL action list supported by ASIC
per stage and put this information in
STATE DB SWITCH_CAPABILITY table

* perform secondary query for ACL action
attributes which parameters are enum values

* implement VS test cases

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

…he route object table value is zero (#1048)

* change in fpmsyncd to  skip the lookup for the Master device name
if the route object table value is zero
.i.e. the route needs to put in the global routing table

* Cannot ping to link-local ipv6 interface address of the switch.

Fixes:
       1. Packets destined to the switch's routing interface link-local ipv6 address
       are not coming to CPU. Hence the ping fails.
       Since all interfaces have the same link-local ipv6 address, all we need is
       a single ip2me /128 route corresponding to this address added in the hardware.
       We don't need fe80 ip2me route added to hardware for every interface. Hence the
       address overlap issue won't arise for the link-local interface address.

       2. Fixed another issue as part of this PR.
       Where the link-local ipv6 neighbors are not learned via netlink by neighsync.
       As a result, we could not add an ipv6 route via link-local nexthop.
       Allow neighsync to learn the link-local neighbors too.

Signed-off-by: kiran.kella@broadcom.com

* Incremental change to the code changes.

* Incremental change to the code changes.

* Incorporated review comments.

* Incorporated review comments.

* Add fe80::/10 route to CPU to forward all locally destined link-local ipv6 packets to CPU.

* Retain fe80.../128 ip2me route in the hardware along with fe80::/10 subnet route.

Signed-off-by: Kiran Kella <kiran.kella@broadcom.com>

In ACL combined mode, v4 and v6 rules are sharing the same
physical table while having separated configuration tables.
The daemon needs to use the configuration table name to store
the counter information.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

)

return type from void to uint64_t.

* [MirrorOrch]: Mirror Session Retention across Warm Reboot

After warm reboot, it is expected that the monitor port of
the mirror session is retained - no changing on the monitor
port withint the ECMP group members and the LAG members. This
is due to the general of the sairedis comparison logic and
the minimalization of SAI function calls during reconciliation.

Changes:
1. Add bake() and postBake() functions in MirrorOrch
   bake() function retrieves the state database information
   and get the VLAN + monitor port information.
   postBake() function leverages the information and recovers
   the active mirror sessions the same as before warm reboot.
2. state database format change
   Instead of storing the object ID of the monitor port, store
   the alias of the monitor port.
   Instead of storing true/false of VLAN header, store the VLAN
   ID.

Update: Freeze doTask() function instead of update() function

With this update, we could fix potential orchagent issues before
the warm reboot when the monitor port was wrongly calculated.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

Remove deprecated mirror session states in the state database

Signed-off-by: Shu0t1an Cheng <shuche@microsoft.com>

* Remove nexthop member from nexthopgroup
on detecting portchannel down

* Code cleanup

* Fix spacing errors

* Create new Test
1. Add 4 PortChannels
2. Add to nexthop group

* Check for 3 NH group members
after bringing down a portchannel