Skip to content

Revert "DS-631 Observation loop (#18843)" #19079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krehermann merged 1 commit into from
Aug 22, 2025
Merged

Revert "DS-631 Observation loop (#18843)" #19079

krehermann merged 1 commit into from
Aug 22, 2025

Conversation

@krehermann
Copy link
Contributor

@krehermann krehermann commented Aug 22, 2025

This reverts commit 9d6bd73.

there is a race failure that is evicting many merges

Requires

Supports

@krehermann krehermann requested review from a team as code owners August 22, 2025 21:29
@krehermann krehermann enabled auto-merge August 22, 2025 21:30
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

👋 krehermann, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Aug 22, 2025

Quality Gate passed Quality Gate passed

Issues
1 New issue
4 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@krehermann krehermann added this pull request to the merge queue Aug 22, 2025
Merged via the queue into develop with commit 81ebe55 Aug 22, 2025
145 of 146 checks passed
@krehermann krehermann deleted the revert/llo-race branch August 22, 2025 22:04
akuzni2 added a commit that referenced this pull request Aug 22, 2025
@akuzni2
Revert "Revert "DS-631 Observation loop (#18843)" (#19079)"
f0b47f3 
This reverts commit 81ebe55.
@akuzni2 akuzni2 mentioned this pull request Aug 22, 2025
Closed
ro-tex added a commit that referenced this pull request Aug 25, 2025
@ro-tex
Reapply "DS-631 Observation loop (#18843)" (#19079)
a35267e 
This reverts commit 81ebe55.
github-merge-queue bot pushed a commit that referenced this pull request Aug 25, 2025
@ro-tex
Reapply "DS-631 Observation loop (#18843)" (#19079) (#19086)
0b1cc20 
* Reapply "DS-631 Observation loop (#18843)" (#19079)

This reverts commit 81ebe55.

* Wait for the observation loop goroutine to exit.

* lint

* Address comments.
HashWrangler pushed a commit that referenced this pull request Aug 25, 2025
@ro-tex @HashWrangler
Reapply "DS-631 Observation loop (#18843)" (#19079) (#19086)
94c3a8c 
* Reapply "DS-631 Observation loop (#18843)" (#19079)

This reverts commit 81ebe55.

* Wait for the observation loop goroutine to exit.

* lint

* Address comments.
JoshC2k added a commit that referenced this pull request Sep 3, 2025
@JoshC2k
Revert "Reapply "DS-631 Observation loop (#18843)" (#19079) (#19086)"
60eec61 
This reverts commit 0b1cc20.
ro-tex added a commit that referenced this pull request Sep 4, 2025
@ro-tex
Revert "Reapply "DS-631 Observation loop (#18843)" (#19079) (#19086)"
4ebf895 
This reverts commit 0b1cc20.
ro-tex added a commit that referenced this pull request Sep 4, 2025
@ro-tex
Reapply "DS-631 Observation loop (#18843)" (#19079)
4c8b531 
This reverts commit 81ebe55.
@ro-tex ro-tex mentioned this pull request Sep 4, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2025
@ro-tex
Revert Observation loop logic (#19222)
ecf2a46 
* Revert "Handle nil opts, no observable streams or other errors in observation loop (#19105)"

This reverts commit f09f384.

* Revert "Reapply "DS-631 Observation loop (#18843)" (#19079) (#19086)"

This reverts commit 0b1cc20.

* Reapply "DS-631 Observation loop (#18843)" (#19079)

This reverts commit 81ebe55.

* Revert "DS-631 Observation loop (#18843)"

This reverts commit 9d6bd73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@akuzni2 akuzni2 akuzni2 approved these changes

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@justinfranco justinfranco Awaiting requested review from justinfranco

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krehermann @vyzaldysanchez @akuzni2