Skip to content

Handle nil opts, no observable streams or other errors in observation loop#19105

Merged
ro-tex merged 10 commits intodevelopfrom
fix/obs_loop_nil_opts
Aug 27, 2025
Merged

Handle nil opts, no observable streams or other errors in observation loop#19105
ro-tex merged 10 commits intodevelopfrom
fix/obs_loop_nil_opts

Conversation

@ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Aug 26, 2025

Requires

Supports

jmank88
jmank88 reviewed Aug 26, 2025
View reviewed changes
@ro-tex @jmank88
Update core/services/llo/observation/data_source.go
6d8d9b6 
Co-authored-by: Jordan Krage <jmank88@gmail.com>
@ro-tex ro-tex requested a review from jmank88 August 26, 2025 13:01
jmank88
jmank88 previously approved these changes Aug 26, 2025
View reviewed changes
@ro-tex ro-tex marked this pull request as ready for review August 26, 2025 13:13
@ro-tex ro-tex requested review from a team as code owners August 26, 2025 13:13
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@ro-tex ro-tex enabled auto-merge August 26, 2025 16:49
jmank88
jmank88 previously approved these changes Aug 26, 2025
View reviewed changes
brunotm
brunotm previously approved these changes Aug 26, 2025
View reviewed changes
@brunotm brunotm dismissed stale reviews from jmank88 and themself via 2b67d4d August 26, 2025 17:46
brunotm
brunotm previously approved these changes Aug 26, 2025
View reviewed changes
@brunotm brunotm requested a review from jmank88 August 26, 2025 17:50
jmank88
jmank88 previously approved these changes Aug 26, 2025
View reviewed changes
DylanTinianov
DylanTinianov previously approved these changes Aug 26, 2025
View reviewed changes
@brunotm brunotm dismissed stale reviews from jmank88 and themself via f2d20f7 August 27, 2025 08:06
@brunotm
Copy link
Collaborator

brunotm commented Aug 27, 2025

@jmank88 @DylanTinianov @ro-tex this is ready to merge.

brunotm
brunotm previously approved these changes Aug 27, 2025
View reviewed changes
@brunotm brunotm force-pushed the fix/obs_loop_nil_opts branch from f2d20f7 to d5e26d9 Compare August 27, 2025 11:42
brunotm
brunotm previously approved these changes Aug 27, 2025
View reviewed changes
jmank88
jmank88 reviewed Aug 27, 2025
View reviewed changes
@brunotm brunotm requested a review from jmank88 August 27, 2025 12:53
@brunotm brunotm force-pushed the fix/obs_loop_nil_opts branch from c449c72 to 88d8698 Compare August 27, 2025 13:02
jmank88
jmank88 previously approved these changes Aug 27, 2025
View reviewed changes
@brunotm brunotm force-pushed the fix/obs_loop_nil_opts branch from 88d8698 to 340b3ed Compare August 27, 2025 13:23
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Aug 27, 2025

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ro-tex ro-tex added this pull request to the merge queue Aug 27, 2025
Merged via the queue into develop with commit f09f384 Aug 27, 2025
150 of 151 checks passed
@ro-tex ro-tex deleted the fix/obs_loop_nil_opts branch August 27, 2025 14:03
JoshC2k added a commit that referenced this pull request Sep 3, 2025
@JoshC2k
Revert "Handle nil opts, no observable streams or other errors in obs…
f42c560 
…ervation loop (#19105)"

This reverts commit f09f384.
@JoshC2k JoshC2k mentioned this pull request Sep 3, 2025
Closed
ro-tex added a commit that referenced this pull request Sep 4, 2025
@ro-tex
Revert "Handle nil opts, no observable streams or other errors in obs…
e780ecf 
…ervation loop (#19105)"

This reverts commit f09f384.
@ro-tex ro-tex mentioned this pull request Sep 4, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2025
@ro-tex
Revert Observation loop logic (#19222)
ecf2a46 
* Revert "Handle nil opts, no observable streams or other errors in observation loop (#19105)"

This reverts commit f09f384.

* Revert "Reapply "DS-631 Observation loop (#18843)" (#19079) (#19086)"

This reverts commit 0b1cc20.

* Reapply "DS-631 Observation loop (#18843)" (#19079)

This reverts commit 81ebe55.

* Revert "DS-631 Observation loop (#18843)"

This reverts commit 9d6bd73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunotm brunotm brunotm left review comments

@jmank88 jmank88 jmank88 approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@swladyka swladyka Awaiting requested review from swladyka

@DylanTinianov DylanTinianov Awaiting requested review from DylanTinianov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ro-tex @brunotm @jmank88 @cedric-cordenier @DylanTinianov