Reapply "DS-631 Observation loop (#18843)" (#19079) #19086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunotm
requested changes
Aug 25, 2025
brunotm
approved these changes
Aug 25, 2025
|
krehermann
approved these changes
Aug 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Aug 25, 2025
HashWrangler
pushed a commit
that referenced
this pull request
Aug 25, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
* Revert "Handle nil opts, no observable streams or other errors in observation loop (#19105)" This reverts commit f09f384. * Revert "Reapply "DS-631 Observation loop (#18843)" (#19079) (#19086)" This reverts commit 0b1cc20. * Reapply "DS-631 Observation loop (#18843)" (#19079) This reverts commit 81ebe55. * Revert "DS-631 Observation loop (#18843)" This reverts commit 9d6bd73.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 81ebe55.
We also add a wait for the observation loop goroutine to exit before we finish out
Close().Requires
Supports