You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing a lot of CPU and memory usage on Staging Mainnet, therefore we're reverting this change, so it doesn't make it into an official core build. We'll keep working on it until we're happy with the performance and then we'll bring it back.
Reverted PRs: #18843 - original implementation #19079 - revert due to a flaky test #19086 - fix the test and reapply #19105 - handle an edge case
I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:
#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.
We are seeing a lot of CPU and memory usage on Staging Mainnet, therefore we're reverting this change, so it doesn't make it into an official core build. We'll keep working on it until we're happy with the performance and then we'll bring it back.
Requires
Supports
Please include in the description which PRs are reverted.
For context, this is a duplicate of my PR from yesterday (#19209) as I don't have the necessary permissions to contribute to this repo yet (ticket pending).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
product-security-plaid-test
bot
requested review from
JoshC2k and
pavel-raykov
We are seeing a lot of CPU and memory usage on Staging Mainnet, therefore we're reverting this change, so it doesn't make it into an official core build. We'll keep working on it until we're happy with the performance and then we'll bring it back.
Reverted PRs:
#18843 - original implementation
#19079 - revert due to a flaky test
#19086 - fix the test and reapply
#19105 - handle an edge case