Refactor lastAttackedBy to hurtBy #4832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test merge
Edits to comply with eslint check
|
Closing to address typescript test |
Also updated relevant help commands.
Normally, Illusion copies everything except the level, so if Zoroark is a different level from the pokemon it's copying, it's very obvious that it's a copy. This isn't a problem normally (because everyone is 50 or 100), but in randbats, it's a big tell, and makes Zoroark weaker than it's supposed to be. And, unrelatedly, everyone thinks it's a bug even though it's not.
This reverts commit 6007583.
And change spacing of help command to match the rest
- Allow unlocking specific names with /unlockname - Expand /unlockip to work for mods - Clarify which names are locked on /ip
|
bump @Marty-D |
|
Hi, very sorry about the delay, I didn't get any of these alerts. This looks pretty good! Would you mind creating a |
|
Yep, can do. And no worries about the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the 'lastAttackedBy' attribute of a Pokemon with an array of attacks that the Pokemon has recently received. This corrects a bug in double battles arising from lastAttackedBy always getting replaced by the most recent attack, which caused Avalanche and Revenge to not double in power when they otherwise should have (e.g. see https://replay.pokemonshowdown.com/gen7doublescustomgame-796785834). This also addresses the corresponding task in #2444.