Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Yang model for SYSTEM_DEFAULTS table #11117

Merged
merged 10 commits into from
Jul 4, 2022
Merged

Add Yang model for SYSTEM_DEFAULTS table #11117

merged 10 commits into from
Jul 4, 2022

Conversation

bingwang-ms
Copy link
Contributor

Signed-off-by: bingwang wang.bing@microsoft.com

Why I did it

This PR is to defind Yang model for SYSTEM_DEFAULTS table.
The table was introduced in PR sonic-net/SONiC#982
The table will be like

"SYSTEM_DEFAULTS": {
        "tunnel_qos_remap": {
            "status": "enabled"
        }
}

How I did it

Add a new yang file sonic-system-defaults.yang.

How to verify it

Verified by UT

collected 3 items                                                                                                                                                                                     

tests/test_sonic_yang_models.py ..                                                                                                                                                              [ 66%]
tests/yang_model_tests/test_yang_model.py .                                                                                                                                                     [100%]

====================================================================================== 3 passed in 2.27 seconds =======================================================================================

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Add Yang model for SYSTEM_DEFAULTS table

Link to config_db schema for YANG module changes

TODO

A picture of a cute animal (not mandatory but encouraged)

@bingwang-ms
Add Yang model for SYSTEM_DEFAULTS table
ac6991c 
Signed-off-by: bingwang <wang.bing@microsoft.com>
@bingwang-ms
Add Yang model for SYSTEM_DEFAULTS table
3946938 
Signed-off-by: bingwang <wang.bing@microsoft.com>
@bingwang-ms
Fix vs test
f28a040 
Signed-off-by: bingwang <wang.bing@microsoft.com>
@qiluo-msft qiluo-msft requested a review from ganglyu June 14, 2022 01:33
@qiluo-msft
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@qiluo-msft
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit 201ae28 into sonic-net:master Jul 4, 2022
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Sep 23, 2022
@yxieca
Merged PR 6324192: Manual merge github master into internal branch
002411d 
Related work items: sonic-net#284, sonic-net#288, sonic-net#624, sonic-net#630, sonic-net#640, sonic-net#2164, sonic-net#2206, sonic-net#2207, sonic-net#2233, sonic-net#2234, sonic-net#2238, sonic-net#8857, sonic-net#10034, sonic-net#10519, sonic-net#10685, sonic-net#10711, sonic-net#10987, sonic-net#10990, sonic-net#11047, sonic-net#11070, sonic-net#11117, sonic-net#11186, sonic-net#11207, sonic-net#11213, sonic-net#11215, sonic-net#11220, sonic-net#11221, sonic-net#11257, sonic-net#11291, sonic-net#11298, sonic-net#11301, sonic-net#11326, sonic-net#11333, sonic-net#11335, sonic-net#11341, sonic-net#11344, sonic-net#11347, sonic-net#11359, sonic-net#11366, sonic-net#11368, sonic-net#11370, sonic-net#11372, sonic-net#11375, sonic-net#11385, sonic-net#11386, sonic-net#11394, sonic-net#11397, sonic-net#11401, sonic-net#11402, sonic-net#11403, sonic-net#11405, sonic-net#11414
@ayurkiv-nvda ayurkiv-nvda mentioned this pull request Feb 24, 2023
Merged
8 tasks
@ayurkiv-nvda ayurkiv-nvda mentioned this pull request Mar 14, 2023
Closed
@mssonicbld
Copy link
Collaborator

@bingwang-ms PR conflicts with 202205 branch

@mssonicbld
Copy link
Collaborator

@bingwang-ms PR conflicts with 202211 branch

@bingwang-ms bingwang-ms mentioned this pull request May 17, 2023
Merged
10 tasks
@bingwang-ms
Copy link
Contributor Author

PR for 202205 branch is filed #15129
The change is already included in 202211 branch. So we don't need to do the cherry-pick to 202211. I have removed the labels.

yxieca pushed a commit that referenced this pull request May 18, 2023
@bingwang-ms
Add Yang model for SYSTEM_DEFAULTS table (#15129)
fd59559 
Why I did it
This PR is to backport PR #11117 into 202205 branch.
This PR is to define Yang model for SYSTEM_DEFAULTS table.
The table was introduced in PR sonic-net/SONiC#982
The table will be like

"SYSTEM_DEFAULTS": {
        "tunnel_qos_remap": {
            "status": "enabled"
        }
}
Work item tracking
Microsoft ADO (https://msazure.visualstudio.com/One/_workitems/edit/23037078)
How I did it
Add a new yang file sonic-system-defaults. Yang.

How to verify it
Verified by UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganglyu ganglyu ganglyu approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@wen587 wen587 wen587 approved these changes

Assignees
No one assigned
Labels
Approved for 202205 Branch Cherry Pick Conflict_202205 Included in 202205 Branch Request for 202205 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bingwang-ms @qiluo-msft @mssonicbld @wen587 @ganglyu @yxieca