Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to persist TSA/B state across reloads #11257

Merged
merged 13 commits into from
Jul 12, 2022
Merged

Changes to persist TSA/B state across reloads #11257

merged 13 commits into from
Jul 12, 2022

Conversation

tjchadaga
Copy link
Contributor

@tjchadaga tjchadaga commented Jun 26, 2022 •
edited
Loading

Why I did it

Changes to save TSA state in configDB and persist TSA/B across reboots

How I did it

  • Added cfgdb table to hold TSA/B state
  • Added handling in bgpcfg to subscribe to TSA state change
  • Added test code and data files

How to verify it

  • Execute TSA, config save, reboot or config reload. After system comes up, check TSC to ensure the system is in Maintenance

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

arlakshm
arlakshm reviewed Jul 1, 2022
View reviewed changes
Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

dockers/docker-fpm-frr/base_image_files/TS Show resolved Hide resolved
dockers/docker-fpm-frr/base_image_files/TSA Show resolved Hide resolved
dockers/docker-fpm-frr/base_image_files/TSB Show resolved Hide resolved
src/sonic-bgpcfgd/bgpcfgd/managers_device_global.py Outdated Show resolved Hide resolved
src/sonic-yang-models/yang-models/sonic-bgp-device-global.yang Outdated Show resolved Hide resolved
@tjchadaga tjchadaga requested a review from abdosi July 2, 2022 00:19
StormLiangMS
StormLiangMS approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjchadaga tjchadaga merged commit 849eb4b into sonic-net:master Jul 12, 2022
@tjchadaga tjchadaga deleted the tsa_reload branch July 12, 2022 07:23
This was referenced Jul 13, 2022
Merged
Merged
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

yxieca pushed a commit that referenced this pull request Jul 28, 2022
@tjchadaga @yxieca
Changes to persist TSA/B state across reloads (#11257)
fc93871
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@tjchadaga @skbarista
Changes to persist TSA/B state across reloads (sonic-net#11257)
7cb44cb
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Sep 23, 2022
@yxieca
Merged PR 6324192: Manual merge github master into internal branch
002411d 
Related work items: sonic-net#284, sonic-net#288, sonic-net#624, sonic-net#630, sonic-net#640, sonic-net#2164, sonic-net#2206, sonic-net#2207, sonic-net#2233, sonic-net#2234, sonic-net#2238, sonic-net#8857, sonic-net#10034, sonic-net#10519, sonic-net#10685, sonic-net#10711, sonic-net#10987, sonic-net#10990, sonic-net#11047, sonic-net#11070, sonic-net#11117, sonic-net#11186, sonic-net#11207, sonic-net#11213, sonic-net#11215, sonic-net#11220, sonic-net#11221, sonic-net#11257, sonic-net#11291, sonic-net#11298, sonic-net#11301, sonic-net#11326, sonic-net#11333, sonic-net#11335, sonic-net#11341, sonic-net#11344, sonic-net#11347, sonic-net#11359, sonic-net#11366, sonic-net#11368, sonic-net#11370, sonic-net#11372, sonic-net#11375, sonic-net#11385, sonic-net#11386, sonic-net#11394, sonic-net#11397, sonic-net#11401, sonic-net#11402, sonic-net#11403, sonic-net#11405, sonic-net#11414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlakshm arlakshm arlakshm left review comments

@qiluo-msft qiluo-msft qiluo-msft left review comments

@StormLiangMS StormLiangMS StormLiangMS approved these changes

@prsunny prsunny Awaiting requested review from prsunny

@yxieca yxieca Awaiting requested review from yxieca

@judyjoseph judyjoseph Awaiting requested review from judyjoseph

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@abdosi abdosi Awaiting requested review from abdosi

Assignees
No one assigned
Labels
Included in 202205 Branch Request for 202205 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tjchadaga @qiluo-msft @arlakshm @StormLiangMS @yxieca