Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency of determine-reboot-cause to process-reboot-cause service #11213

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

sujinmkang
Copy link
Collaborator

Database container takes long time ( more than 1.5 minutes ) on some vendor platforms.
This makes the determine-reboot-cause starts later than process-reboot-cause service.
And that results in the incorrect reboot-cause determination.

Why I did it

Database container takes long time ( more than 1.5 minutes ) on some vendor platforms.
This makes the determine-reboot-cause starts later than process-reboot-cause service.
And that results in the incorrect reboot-cause determination.

How I did it

Add the dependency of determine-reboot-cause service to process-reboot-cause service

How to verify it

Reboot and check the reboot-cause once the device boots up.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@sujinmkang sujinmkang requested a review from lguohan as a code owner June 21, 2022 21:36
@sujinmkang sujinmkang requested a review from a team July 8, 2022 18:33
Copy link
Contributor

@lizhuhuams lizhuhuams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@mlok-nokia
Copy link
Contributor

This PR is required to be merged to 202205 branch

yxieca pushed a commit that referenced this pull request Nov 28, 2022
…se service (#11213)

Why I did it
Database container takes long time ( more than 1.5 minutes ) on some vendor platforms.
This makes the determine-reboot-cause starts later than process-reboot-cause service.
And that results in the incorrect reboot-cause determination.

How I did it
Add the dependency of determine-reboot-cause service to process-reboot-cause service
@byu343
Copy link
Contributor

byu343 commented Aug 1, 2023

@yxieca @StormLiangMS When investigating an occasionally test failure related for unexpected 'show reboot-cause history' on platform_tests/test_reboot.py::test_warm_reboot on 202012, we found that the issue here could be the cause. Can you please backport this PR to 202012 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants