-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[syncd] extend syncd service script to support both warm/cold shutdown #2238
Conversation
- cold shutdown is used by regular service stop and/or fast reboot - warm shutdown is used by warm restart and/or warm reboot Signed-off-by: Ying Xie <ying.xie@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
Qi, Your claim of "WARM_RESTART|*" can only used during boot up path doesn't make sense to me. I cannot find any document to support this claim. Can you point me to the document made this claim? Warm reboot is a whole feature, which includes shut down path and boot up path. Stating that the warm boot flag can only be used in boot up path is odd. Regards, |
…et#2238) * [ACL]Avoid incrementing crm count when ACL rule create fails
Update sonic-utilities submodule to include below commits: 7070794 Fix DBConfig not initialize issue in pfcwd (#2238) b5d6659 [config/load_mgmt_config] Support load IPv6 mgmt IP (#2206) 3274b0e Added bf_drivers.log to zipped dump after execution of "show techsupport" (#2164) 8dee36c [portstat] Update portstat to use CounterTable API (#2207) 7d9faf3 Added support for Sonic cross-compilation build. (#2233) c3620fc [GCU] Moving UniqueLanes from only validating moves, to be a supplemental YANG validator (#2234) Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Related work items: sonic-net#284, sonic-net#288, sonic-net#624, sonic-net#630, sonic-net#640, sonic-net#2164, sonic-net#2206, sonic-net#2207, sonic-net#2233, sonic-net#2234, sonic-net#2238, sonic-net#8857, sonic-net#10034, sonic-net#10519, sonic-net#10685, sonic-net#10711, sonic-net#10987, sonic-net#10990, sonic-net#11047, sonic-net#11070, sonic-net#11117, sonic-net#11186, sonic-net#11207, sonic-net#11213, sonic-net#11215, sonic-net#11220, sonic-net#11221, sonic-net#11257, sonic-net#11291, sonic-net#11298, sonic-net#11301, sonic-net#11326, sonic-net#11333, sonic-net#11335, sonic-net#11341, sonic-net#11344, sonic-net#11347, sonic-net#11359, sonic-net#11366, sonic-net#11368, sonic-net#11370, sonic-net#11372, sonic-net#11375, sonic-net#11385, sonic-net#11386, sonic-net#11394, sonic-net#11397, sonic-net#11401, sonic-net#11402, sonic-net#11403, sonic-net#11405, sonic-net#11414
Signed-off-by: Ying Xie ying.xie@microsoft.com
- What I did
Move syncd shutdown knowledge to syncd service script. So that there is no more special handling for syncd service in normal/fast-reboot/warm-reboot cases.
- How to verify it
Regular service stop:
command: service swss stop
Thu Nov 8 16:50:40 UTC 2018 - Stopping swss service...
Thu Nov 8 16:50:40 UTC 2018 - Locking /tmp/swss-syncd-lock from swss service
Thu Nov 8 16:50:40 UTC 2018 - Locked /tmp/swss-syncd-lock (10) from swss service
Thu Nov 8 16:50:40 UTC 2018 - Warm boot flag: swss false.
Thu Nov 8 16:50:42 UTC 2018 - Stopped swss service...
Thu Nov 8 16:50:42 UTC 2018 - Unlocking /tmp/swss-syncd-lock (10) from swss service
Thu Nov 8 16:50:42 UTC 2018 - Stopping syncd service...
Thu Nov 8 16:50:42 UTC 2018 - Locking /tmp/swss-syncd-lock from syncd service
Thu Nov 8 16:50:42 UTC 2018 - Locked /tmp/swss-syncd-lock (10) from syncd service
Thu Nov 8 16:50:42 UTC 2018 - Warm boot flag: syncd false.
Thu Nov 8 16:50:42 UTC 2018 - cold shutdown syncd process ...
Thu Nov 8 16:50:46 UTC 2018 - Finished cold shutdown syncd process ...
Thu Nov 8 16:50:48 UTC 2018 - Stopped syncd service...
Thu Nov 8 16:50:48 UTC 2018 - Unlocking /tmp/swss-syncd-lock (10) from syncd service
Warm stop syncd (simulating syncd warm restart):
commands:
config warm_restart enable system
service syncd stop
Thu Nov 8 16:53:19 UTC 2018 - Stopping syncd service...
Thu Nov 8 16:53:19 UTC 2018 - Locking /tmp/swss-syncd-lock from syncd service
Thu Nov 8 16:53:19 UTC 2018 - Locked /tmp/swss-syncd-lock (10) from syncd service
Thu Nov 8 16:53:19 UTC 2018 - Warm boot flag: syncd true.
Thu Nov 8 16:53:19 UTC 2018 - warm shutdown syncd process ...
Thu Nov 8 16:53:44 UTC 2018 - Finished warm shutdown syncd process ...
Thu Nov 8 16:53:46 UTC 2018 - Stopped syncd service...
Thu Nov 8 16:53:46 UTC 2018 - Unlocking /tmp/swss-syncd-lock (10) from syncd service
fast-reboot simulation: docker kill swss
Thu Nov 8 16:55:27 UTC 2018 - Stopping swss service...
Thu Nov 8 16:55:27 UTC 2018 - Locking /tmp/swss-syncd-lock from swss service
Thu Nov 8 16:55:27 UTC 2018 - Locked /tmp/swss-syncd-lock (10) from swss service
Thu Nov 8 16:55:27 UTC 2018 - Warm boot flag: swss false.
Thu Nov 8 16:55:27 UTC 2018 - Stopped swss service...
Thu Nov 8 16:55:27 UTC 2018 - Unlocking /tmp/swss-syncd-lock (10) from swss service
Thu Nov 8 16:55:27 UTC 2018 - Stopping syncd service...
Thu Nov 8 16:55:27 UTC 2018 - Locking /tmp/swss-syncd-lock from syncd service
Thu Nov 8 16:55:27 UTC 2018 - Locked /tmp/swss-syncd-lock (10) from syncd service
Thu Nov 8 16:55:28 UTC 2018 - Warm boot flag: syncd false.
Thu Nov 8 16:55:28 UTC 2018 - cold shutdown syncd process ...
Thu Nov 8 16:55:28 UTC 2018 - Finished cold shutdown syncd process ...
Thu Nov 8 16:55:30 UTC 2018 - Stopped syncd service...
Thu Nov 8 16:55:30 UTC 2018 - Unlocking /tmp/swss-syncd-lock (10) from syncd service
full system warm-reboot simulation (swss service left syncd alone, syncd service will be stopped later):
commands:
config warm_restart enable system
docker kill swss
Thu Nov 8 16:56:56 UTC 2018 - Stopping swss service...
Thu Nov 8 16:56:56 UTC 2018 - Locking /tmp/swss-syncd-lock from swss service
Thu Nov 8 16:56:56 UTC 2018 - Locked /tmp/swss-syncd-lock (10) from swss service
Thu Nov 8 16:56:56 UTC 2018 - Warm boot flag: swss true.
Thu Nov 8 16:56:56 UTC 2018 - Stopped swss service...
Thu Nov 8 16:56:56 UTC 2018 - Unlocking /tmp/swss-syncd-lock (10) from swss service