chore(ci): helm deployment #129
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @dan-ziv and @guyvelleman)
.github/workflows/push_backend_images.yml, line 18 at r2 (raw file):
gcp_token: ${{ secrets.STARKGATE_SA }} AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
why the AWS creds needed here?
the push is to gcr
.github/workflows/push_frontend_images.yml, line 18 at r2 (raw file):
gcp_token: ${{ secrets.STARKGATE_SA }} AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
same as above
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @dan-ziv, @guyvelleman, and @roi-amaler-starkware)
.github/workflows/push_backend_images.yml, line 18 at r2 (raw file):
Previously, roi-amaler-starkware wrote…
why the AWS creds needed here?
the push is to gcr
For download the helm repo from S3 (Deployment job).
'push-frontend-image' module only calls './.github/workflows/gcr_push_workflow.yml' workflow
with the relevant variables.
## [1.2.0-dev.2](v1.2.0-dev.1...v1.2.0-dev.2) (2022-04-11) ### 🔧 Fixes * **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
## [1.2.0-dev.3](v1.2.0-dev.2...v1.2.0-dev.3) (2022-04-12) ### 🔧 Fixes * **Faq:** update question 8 ([#149](#149)) ([67f50f7](67f50f7))
…-libs/starkgate-frontend into guy/master/dev_helm_deployment
## [1.2.0-dev.4](v1.2.0-dev.3...v1.2.0-dev.4) (2022-04-13) ### 🔧 Fixes * unsupported chain id does not showing ([#151](#151)) ([017ce0a](017ce0a))
## [1.2.0-dev.5](v1.2.0-dev.4...v1.2.0-dev.5) (2022-04-13) ### 🔧 Fixes * app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
## [1.2.0](v1.1.0...v1.2.0) (2022-04-13) ### 🧩 Features * terms of use ([#141](#141)) ([8d9fe79](8d9fe79)) ### 🔧 Fixes * app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861)) * **Faq:** update question 8 ([#149](#149)) ([67f50f7](67f50f7)) * **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e)) * unsupported chain id does not showing ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv
force-pushed
the
dev
branch
3 times, most recently
from
70a0182 to
14ae412
Compare
…guy/master/dev_helm_deployment
…guy/master/dev_helm_deployment
|
🎉 This PR is included in version 1.2.1-dev.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
Checklist
<type>[optional scope]: <description>, e.g:fix: prevent racing of requestsThis change is