Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure keycard account can send transaction after upgrading from v1 to v2 #20552

Closed
qfrank opened this issue Jun 25, 2024 · 0 comments · Fixed by #20845
Closed

Ensure keycard account can send transaction after upgrading from v1 to v2 #20552

qfrank opened this issue Jun 25, 2024 · 0 comments · Fixed by #20845
Assignees
@flexsurfer
Labels
feature feature requests
Milestone
2.30.0

Comments

@qfrank
Copy link
Contributor

qfrank commented Jun 25, 2024 •
edited
Loading

Feature Issue

Background

There is uncertainty about whether a keycard account can send transactions after upgrading from v1 to v2. Additionally, users are currently unable to log in after upgrading to v2. Once the login issue is resolved, we need to ensure that keycard accounts can successfully send transactions.

Acceptance Criteria

  • Keycard users should be able to send transactions after upgrading from v1 to v2.

Note from @cammellos :
we want v1 users to be able to send their funds using keycard, barebone, otherwise we would be locking them out potentially from their funds (stretch goal, but keycard users on average tends likely to have more funds/care more about their funds, so locking them out I think would look very bad for a wallet)
@qfrank qfrank added the feature feature requests label Jun 25, 2024
@qfrank qfrank added this to the 2.30.0 Beta milestone Jun 25, 2024
@qfrank qfrank self-assigned this Jun 25, 2024
@qfrank qfrank moved this to In Progress in Status Desktop/Mobile Board Jun 25, 2024
@qfrank qfrank removed their assignment Jun 25, 2024
@flexsurfer flexsurfer self-assigned this Jun 27, 2024
@flexsurfer flexsurfer mentioned this issue Jul 22, 2024
Merged
flexsurfer added a commit that referenced this issue Jul 26, 2024
@flexsurfer
Ensure keycard account can send transaction after upgrading from v1 t…
170d95d 
…o v2 #20552
siddarthkay pushed a commit that referenced this issue Jul 26, 2024
@flexsurfer @siddarthkay
Ensure keycard account can send transaction after upgrading from v1 t…
f23a073 
…o v2 #20552
flexsurfer added a commit that referenced this issue Jul 26, 2024
@flexsurfer
Ensure keycard account can send transaction after upgrading from v1 t…
fcbe9cd 
…o v2 #20552
flexsurfer added a commit that referenced this issue Jul 26, 2024
@flexsurfer
Ensure keycard account can send transaction after upgrading from v1 t…
73777e0 
…o v2 #20552 (#20845)
@github-project-automation github-project-automation bot moved this from In Progress to Done in Status Desktop/Mobile Board Jul 26, 2024
ilmotta pushed a commit that referenced this issue Jul 28, 2024
@flexsurfer @ilmotta
Ensure keycard account can send transaction after upgrading from v1 t…
33e2417 
…o v2 #20552 (#20845)
ilmotta added a commit that referenced this issue Jul 30, 2024
@ilmotta
Update release branch 2.30.x (#20903)
0f15c01 
Revisions from develop:

- 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902)
- 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721)
- 8c2d539 Enabling WalletConnect feature flag (#20906)
- 67c83b1 fix(wallet): remove edit routes button in bridging (#20874)
- 11a84ba feat(wallet): disable complex routing (#20901)
- 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846)
- 4586f80 Add toggle in advanced settings for mobile data
- 55c620e fix: create password for small screen (#20645)
- 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862)
- 9065395 chore(settings): Disable telemetry option (#20881)
- d27ab75 fix_:display group message using the new ui (#20787)
- c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683)
- 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845)
- a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888)
- a671c70 fix broken screen and navigation when syncing fails (#20887)
- a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799)
- 2e9fa22 feat: wallet router v2 (#20631)
- 737d8c4 rename sub to fix error when requesting to join community (#20868)
- 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883)
- c1d2d44 perf: Fix app freeze after login (#20729)
- 0fed811 e2e: updated testnet switching and added one test into smoke
- 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854)
- be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875)
- eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873)
- fe54a25 fix: not clearing network & web3-wallet on logout (#20886)
- 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836)
- 2ffbdac WalletConnect show expired toast (#20857)
- 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867)
- ff88049 Fix WalletConnect header alignment on Android (#20860)
- cee2124 WalletConnect no internet edge-cases (#20826)
- 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825)
- 4989c92 fix_: Adding own address as saved addresses (#20839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flexsurfer flexsurfer

Labels
feature feature requests
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.30.0
Development

Successfully merging a pull request may close this issue.

Ensure keycard account can send transaction after upgrading from v1 to v2 status-im/status-mobile
2 participants
@flexsurfer @qfrank