fix_: Adding own wallet address as saved addresses

[smohamedjavid]

fixes #20702
fixes #20751

Summary

This PR

• prevents the user from saving their wallet address as the saved address
• fixes button not capturing taps when the keyboard is open

Review notes

The bug is caused by the validation failure when using a multi-chain prefix. This PR updates the validation method to extract and validate the address.

Platforms

• Android
• iOS

Steps to test

• Open Status
• Navigate to the Wallet tab or Open share screen
• Copy the address of your wallet account address with multi-chain prefixes
• Navigate to Profile > Wallet > Saved addresses and tap on +
• Paste the address into the input field
• Verify the error is thrown
• Copy any of the saved addresses with multi-chain prefixes
• Paste the address into the input field
• Verify the error is thrown
• Verify the paste button and [-] button are tappable when the keyboard is open

status: ready

[status-im-auto]

Jenkins Builds

Click to see older builds (4)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	501fe7a	#1	2024-07-22 10:05:56	~5 min	tests	📄log
✔️	501fe7a	#1	2024-07-22 10:06:51	~6 min	android	🤖apk 📲
✔️	501fe7a	#1	2024-07-22 10:07:47	~7 min	android-e2e	🤖apk 📲
✔️	501fe7a	#1	2024-07-22 10:09:32	~9 min	ios	📱ipa 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	0ce2680	#2	2024-07-23 10:48:08	~4 min	tests	📄log
✔️	0ce2680	#2	2024-07-23 10:51:27	~8 min	android	🤖apk 📲
✔️	0ce2680	#2	2024-07-23 10:51:40	~8 min	android-e2e	🤖apk 📲
✔️	0ce2680	#2	2024-07-23 10:57:35	~14 min	ios	📱ipa 📲
✔️	a2ce5e3	#3	2024-07-24 12:27:47	~6 min	android-e2e	🤖apk 📲
✔️	a2ce5e3	#3	2024-07-24 12:29:38	~8 min	tests	📄log
✔️	a2ce5e3	#3	2024-07-24 12:30:40	~9 min	android	🤖apk 📲
✔️	a2ce5e3	#3	2024-07-24 12:31:17	~10 min	ios	📱ipa 📲

[ulisesmac]

Thanks for the PR @smohamedjavid

Looks great!

[status-im-auto]

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 1
Passed tests: 6

IDs of expected to fail tests: 727232 

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find `EditBox` by `accessibility id`: `add-address-to-watch` Device 1: Type `0x8d2413447ff297d30bdc475f6d5cb00254685aae` to `EditBox` critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name) ../views/wallet_view.py:163: in add_watch_only_account self.account_has_activity_label.wait_for_visibility_of_element() ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element [[Missing networks in account address, https://github.com//issues/20166]] Device sessions Device 1: Steps, video, logs

Passed tests (6)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions Device 1: Steps, video, logs

2. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions Device 1: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

[VolodLytvynenko]

hi @smohamedjavid thank you for PR.

I'm not sure if this is an issue. In my opinion, watch-only addresses should be able to be added as saved . WDYT? However, this is a very low priority issue and it's better not to waste time on it. The PR can be merged. Let me know if this issue is decided to be fixed in this PR, and I can recheck it.

PR_ISSUE 1: Watch-only addresses can't be saved

Steps:

1. Go to wallet
2. Add watch only account
3. Go to Profile -> wallet -> saved addresses
4. Attempt to save the watch-only address into "saved" list

Actual result:

Watch-only addresses cannot be saved into the "saved" list.

Expected result:

Watch-only addresses should be saved into the "saved" list without validation

[smohamedjavid]

Hey @VolodLytvynenko - Thanks for testing the PR 🙏

I'm not sure if this is an issue. In my opinion, watch-only addresses should be able to be added as saved . WDYT? However, this is a very low priority issue and it's better not to waste time on it. The PR can be merged. Let me know if this issue is decided to be fixed in this PR, and I can recheck it.

IMO, this will create confusion for the users. Watched addresses help you view the assets in that address (moreover, it is treated as an own account except for the ability to transact) where the saved address is NOT.

Watched addresses and saved addresses are shown to the users in the Send to screen. If they see the same address on both, it will create confusion.

I will merge this PR with the existing fix. if you feel it's something we should check, we can initiate a discussion with the design team and get their input as well.