WalletConnect no internet edge-cases #20826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (48)
|
clauxx
force-pushed
the
feat/wallet-connect-no-internet
branch
4 times, most recently
from
c8de0db to
7c94654
Compare
clauxx
requested review from
alwx,
shivekkhurana,
flexsurfer,
J-Son89 and
ilmotta
J-Son89
reviewed
Jul 21, 2024
J-Son89
reviewed
Jul 21, 2024
src/status_im/contexts/wallet/wallet_connect/modals/common/footer/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
approved these changes
Jul 21, 2024
alwx
approved these changes
Jul 22, 2024
|
@qoqobolo @pavloburykh The PR is ready for testing |
71% of end-end tests have passedFailed tests (1)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (5)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
@clauxx could you resolve the conflicts please? I'll start testing after that, thanks! |
|
@qoqobolo done 👍 |
|
Hey @clauxx, I found quite hard to review this PR due to the amount of commits coming from other already merged PRs. Even the large number of changes coming from the recently changed translations file. Sorry if I'm out of context, but why are we basing the PR branch off of |
Yeah, good point. I have to rebase. Initially the changes here depended on the other branch |
clauxx
force-pushed
the
feat/wallet-connect-no-internet
branch
2 times, most recently
from
08a2839 to
0611a81
Compare
|
@ilmotta Sorry for this, seems like during a previous rebase the tree got messed up. Should be good to review and test now 👍 |
|
Thanks @clauxx, ping me please as soon as you have news👍 |
clauxx
force-pushed
the
feat/wallet-connect-no-internet
branch
from
1549eaf to
e091ba5
Compare
|
@qoqobolo ready to be checked again. Added some changes to make it easier for the other PR to rebase (cc @Parveshdhull). |
|
Thanks @clauxx, LGTM. |
ilmotta
pushed a commit
that referenced
this pull request
Jul 28, 2024
* feat: only initialize wc if internet online * feat: no internet toast for session establishment * feat: no internet banner on session requests * feat: reloading walletconnect on connection change * fix: re-initialize only when previously failed to * fix: removed legacy net-info ns * ref: renamed :network-status to :network/status * ref: moved network subs to own "category" * fix: device network fx args * fix: tests & showing persisted dapps when offline * fix: addressed review comments * fix: rebase issues * fix: linting * fix: usage of web3-wallet (#20864) * fix: moved networks to contextx and renaming * ref: moved building supported namespaces into fx
ilmotta
added a commit
that referenced
this pull request
Jul 30, 2024
Revisions from develop: - 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902) - 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721) - 8c2d539 Enabling WalletConnect feature flag (#20906) - 67c83b1 fix(wallet): remove edit routes button in bridging (#20874) - 11a84ba feat(wallet): disable complex routing (#20901) - 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846) - 4586f80 Add toggle in advanced settings for mobile data - 55c620e fix: create password for small screen (#20645) - 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862) - 9065395 chore(settings): Disable telemetry option (#20881) - d27ab75 fix_:display group message using the new ui (#20787) - c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683) - 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845) - a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888) - a671c70 fix broken screen and navigation when syncing fails (#20887) - a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799) - 2e9fa22 feat: wallet router v2 (#20631) - 737d8c4 rename sub to fix error when requesting to join community (#20868) - 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883) - c1d2d44 perf: Fix app freeze after login (#20729) - 0fed811 e2e: updated testnet switching and added one test into smoke - 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854) - be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875) - eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873) - fe54a25 fix: not clearing network & web3-wallet on logout (#20886) - 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836) - 2ffbdac WalletConnect show expired toast (#20857) - 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867) - ff88049 Fix WalletConnect header alignment on Android (#20860) - cee2124 WalletConnect no internet edge-cases (#20826) - 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825) - 4989c92 fix_: Adding own address as saved addresses (#20839)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20802
fixes #20760
fixes #20764
Summary
Fixing issues related to internet connection in wallet connect.
Changes included:
net-infons from legacy to status-im and adapted to guidelinesstatus: ready