Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue with scrolling WalletConnect transaction on Android #20867

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix Issue with scrolling WalletConnect transaction on Android #20867

merged 2 commits into from
Jul 25, 2024

Conversation

Parveshdhull
Copy link
Member

fixes #20795

status: ready

@Parveshdhull Parveshdhull self-assigned this Jul 24, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jul 24, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e526662 #1 2024-07-24 11:05:14 ~5 min tests 📄log
✔️ e526662 #1 2024-07-24 11:09:09 ~8 min android-e2e 🤖apk 📲
✔️ e526662 #1 2024-07-24 11:09:12 ~9 min android 🤖apk 📲
✔️ e526662 #1 2024-07-24 11:09:53 ~9 min ios 📱ipa 📲
✔️ be2557c #2 2024-07-25 07:15:35 ~5 min tests 📄log
✔️ be2557c #2 2024-07-25 07:19:01 ~8 min android-e2e 🤖apk 📲
✔️ be2557c #2 2024-07-25 07:19:09 ~8 min android 🤖apk 📲
✔️ be2557c #2 2024-07-25 07:19:14 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c2e6165 #3 2024-07-25 08:35:25 ~4 min tests 📄log
✔️ c2e6165 #3 2024-07-25 08:39:01 ~8 min android-e2e 🤖apk 📲
✔️ c2e6165 #3 2024-07-25 08:39:08 ~8 min android 🤖apk 📲
✔️ c2e6165 #3 2024-07-25 08:39:32 ~8 min ios 📱ipa 📲
✔️ 0d638d2 #4 2024-07-25 12:40:25 ~5 min tests 📄log
✔️ 0d638d2 #4 2024-07-25 12:40:56 ~6 min android-e2e 🤖apk 📲
✔️ 0d638d2 #4 2024-07-25 12:42:57 ~8 min android 🤖apk 📲
❌ 0d638d2 #4 2024-07-25 12:49:12 ~14 min ios 📄log

@status-im-auto
Copy link
Member

71% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 1
Passed tests: 5

IDs of failed tests: 727229 

IDs of expected to fail tests: 727232

Failed tests (1)

Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
    Device 2: `Text` is `0.01439 ETH` 

    critical/test_wallet.py:156: in test_wallet_send_eth
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.4836 but expected to be 0.4837



    Expected to fail tests (1)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Find EditBox by accessibility id: add-address-to-watch
    Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox 

    critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

    [[Missing networks in account address, https://github.com//issues/20166]]

    Device sessions

    Passed tests (5)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    @clauxx clauxx requested review from shivekkhurana and alwx July 24, 2024 12:04
    clauxx
    clauxx approved these changes Jul 24, 2024
    View reviewed changes
    Copy link
    Member

    @clauxx clauxx left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good! Thank you!

    @shivekkhurana
    Copy link
    Contributor

    Cute.

    @clauxx
    Copy link
    Member

    clauxx commented Jul 25, 2024

    @qoqobolo @pavloburykh ready to be tested

    @mariia-skrypnyk mariia-skrypnyk self-assigned this Jul 25, 2024
    @qoqobolo
    Copy link
    Contributor

    Hey @Parveshdhull , thanks for the fix!
    Super minor issue but maybe it's also a super easy fix? :) Take a look pls

    ISSUE 1: The last line of the message is hidden

    Checked on Pixel 7a

    video_2024-07-25_10-22-16.mp4

    @Parveshdhull Parveshdhull force-pushed the fix/wallet-connect-scroll branch from be2557c to c2e6165 Compare July 25, 2024 08:30
    @Parveshdhull
    Copy link
    Member Author

    Thank you @qoqobolo for testing the PR and finding the issue. Should be fixed now.

    @mariia-skrypnyk
    Copy link

    Hey @Parveshdhull !

    Thanks for your quick fixes.
    I checked both platforms and scroll regression in communities, group chats, info on create profile screen etc.
    PR can be merged!

    @Parveshdhull Parveshdhull force-pushed the fix/wallet-connect-scroll branch from c2e6165 to 0d638d2 Compare July 25, 2024 12:34
    @siddarthkay siddarthkay merged commit 402eb83 into develop Jul 25, 2024
    5 of 6 checks passed
    @siddarthkay siddarthkay deleted the fix/wallet-connect-scroll branch July 25, 2024 12:52
    ilmotta pushed a commit that referenced this pull request Jul 28, 2024
    @Parveshdhull @ilmotta
    fix Issue with scrolling WalletConnect transaction on Android (#20867)
    cb7f0bc
    ilmotta added a commit that referenced this pull request Jul 30, 2024
    @ilmotta
    Update release branch 2.30.x (#20903)
    0f15c01 
    Revisions from develop:

- 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902)
- 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721)
- 8c2d539 Enabling WalletConnect feature flag (#20906)
- 67c83b1 fix(wallet): remove edit routes button in bridging (#20874)
- 11a84ba feat(wallet): disable complex routing (#20901)
- 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846)
- 4586f80 Add toggle in advanced settings for mobile data
- 55c620e fix: create password for small screen (#20645)
- 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862)
- 9065395 chore(settings): Disable telemetry option (#20881)
- d27ab75 fix_:display group message using the new ui (#20787)
- c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683)
- 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845)
- a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888)
- a671c70 fix broken screen and navigation when syncing fails (#20887)
- a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799)
- 2e9fa22 feat: wallet router v2 (#20631)
- 737d8c4 rename sub to fix error when requesting to join community (#20868)
- 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883)
- c1d2d44 perf: Fix app freeze after login (#20729)
- 0fed811 e2e: updated testnet switching and added one test into smoke
- 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854)
- be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875)
- eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873)
- fe54a25 fix: not clearing network & web3-wallet on logout (#20886)
- 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836)
- 2ffbdac WalletConnect show expired toast (#20857)
- 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867)
- ff88049 Fix WalletConnect header alignment on Android (#20860)
- cee2124 WalletConnect no internet edge-cases (#20826)
- 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825)
- 4989c92 fix_: Adding own address as saved addresses (#20839)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

    @clauxx clauxx clauxx approved these changes

    @shivekkhurana shivekkhurana shivekkhurana approved these changes

    @alwx alwx Awaiting requested review from alwx

    Assignees

    @Parveshdhull Parveshdhull

    @mariia-skrypnyk mariia-skrypnyk

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Issue with scrolling WalletConnect transaction on Android
    8 participants
    @Parveshdhull @status-im-auto @shivekkhurana @clauxx @qoqobolo @mariia-skrypnyk @mohsen-ghafouri @siddarthkay