soroban-rpc: Add logging for HTTP requests and JSONRPC requests #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
standarize-logging
branch
5 times, most recently
from
61ae269 to
0314e89
Compare
paulbellamy
suggested changes
Apr 13, 2023
2opremio
force-pushed
the
standarize-logging
branch
2 times, most recently
from
78fbc12 to
cf7cec7
Compare
2opremio
commented
Apr 14, 2023
tamirms
reviewed
Apr 14, 2023
2opremio
commented
Apr 14, 2023
Each HTTP request is assigned an ID logged using the the stellar/go/support/http middleware Within each HTTP request, each JSONRPC request is logged using the global HTTP ID and the per-request JSONRPC id. Additionally, I added the version and commit of soroban-rpc to the startup log.
2opremio
force-pushed
the
standarize-logging
branch
from
cf7cec7 to
22fbf5f
Compare
2opremio
force-pushed
the
standarize-logging
branch
from
2e712d2 to
f86eac3
Compare
tamirms
approved these changes
Apr 17, 2023
I'd suggest 2 lines per request (start and finish). In the past I've found having both useful for debugging, though start could be debug level. |
paulbellamy
approved these changes
Apr 17, 2023
2opremio
force-pushed
the
standarize-logging
branch
from
d8ddc47 to
ef249be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Each HTTP request is assigned an ID logged using the the stellar/go/support/http middleware
Within each HTTP request, each JSONRPC request is logged using the global HTTP ID and the per-request JSONRPC ID.
Additionally, I added the version and commit of soroban-rpc to the startup log.
Why
Done as part of #497
Known limitations
N/A