OIDC #168
OIDC #168
Conversation
WalkthroughWalkthroughThe recent changes primarily involve updates to various files across the codebase, focusing on enhancing scheduled tasks, improving documentation, updating dependencies, and refining user interface components. The modifications include changing cron job timings for Docker publishing, updating URLs in documentation, enhancing the Go module dependencies, and restructuring several components for improved styling and functionality. Additionally, new documentation files have been introduced to assist users in configuring and installing the application. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
participant DockerPublisher
participant GoModule
User->>Documentation: Access updated links
Documentation->>User: Provide correct URLs
User->>DockerPublisher: Trigger Docker publish
DockerPublisher->>GoModule: Check updated dependencies
GoModule-->>DockerPublisher: Confirm updates
DockerPublisher-->>User: Complete publishing process
Assessment against linked issues
Possibly related PRs
Tip OpenAI O1 model for chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post
Actionable comments posted: 10
Outside diff range, codebase verification and nitpick comments (6)
backend/app/api/providers/extractors.go (1)
58-94: Ensure consistency in error messages.While the function is robust, consider making error messages consistent in style and detail.
// Example consistent error message return oauthForm, errors.New("failed to parse OAuth form: invalid content type")backend/internal/core/services/service_oauth.go (1)
120-173: Review User Registration Logic inCreateUserThe method handles user registration and group assignment. Ensure that the logic for creating groups and assigning roles is secure and follows best practices. Consider adding role-based access control checks.
// Consider implementing role-based access control for user creationbackend/internal/data/ent/oauth.go (2)
17-35: Review OAuth Entity StructureThe
OAuthentity is well-defined with fields for provider and subject. Ensure that theProviderandSubfields are indexed for efficient querying, especially if they are frequently used in lookups.// Consider adding indexes to the Provider and Sub fields for better query performance
46-57: Enhance Error Messages inUserOrErrMethodThe error messages returned when edges are not loaded or found could be more descriptive to aid in debugging and understanding the context of the error.
return nil, &NotLoadedError{edge: "user", message: "User edge not loaded or found"}backend/internal/data/ent/user_create.go (2)
193-197: Ensure OAuth ID ValidationThe
AddOauthIDsmethod currently lacks explicit validation to ensure that the OAuth IDs correspond to existing entities in the database. It is advisable to implement a validation mechanism to verify the existence of these IDs before adding them. This will enhance the robustness and reliability of the system.
- Consider adding a check to confirm that each OAuth ID exists in the database before calling
AddOauthIDs.Analysis chain
OAuth ID Addition Logic.
The
AddOauthIDsmethod adds OAuth relationships by ID. Confirm that IDs are validated and correspond to existing OAuth entities.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that OAuth IDs are validated before being added. # Test: Search for `AddOauthIDs` usage. Expect: Validation logic in place. rg --type go 'AddOauthIDs'Length of output: 1308
Script:
#!/bin/bash # Search for all instances where AddOauthIDs is called and examine the surrounding code for validation logic. rg --type go 'AddOauthIDs' -A 5 -B 5Length of output: 5437
199-206: OAuth Entity Validation Missing.The
AddOauthandAddOauthIDsmethods do not currently include validation logic for OAuth entities. It is advisable to implement validation to ensure these entities are properly initialized before being added.
- Consider adding validation logic within the
AddOauthmethod or before calling it to ensure OAuth entities are valid.Analysis chain
OAuth Entity Addition Logic.
The
AddOauthmethod adds OAuth entities directly. Ensure that these entities are properly initialized and validated.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that OAuth entities are validated before being added. # Test: Search for `AddOauth` usage. Expect: Validation logic in place. rg --type go 'AddOauth'Length of output: 1900
Script:
#!/bin/bash # Description: Search for the implementation of AddOauth and AddOauthIDs methods to check for validation logic. # Search for the AddOauth method implementation in user_create.go ast-grep --lang go --pattern $'func (uc *UserCreate) AddOauth(o ...*OAuth) *UserCreate { $$$ }' # Search for the AddOauthIDs method implementation in user_create.go ast-grep --lang go --pattern $'func (uc *UserCreate) AddOauthIDs(ids ...uuid.UUID) *UserCreate { $$$ }'Length of output: 979
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
backend/go.sumis excluded by!**/*.sumbackend/internal/data/migrations/migrations/atlas.sumis excluded by!**/*.sum
Files selected for processing (37)
- backend/app/api/providers/extractors.go (2 hunks)
- backend/app/api/providers/oauth.go (1 hunks)
- backend/app/api/routes.go (3 hunks)
- backend/go.mod (5 hunks)
- backend/internal/core/services/all.go (2 hunks)
- backend/internal/core/services/service_oauth.go (1 hunks)
- backend/internal/core/services/service_user.go (1 hunks)
- backend/internal/core/services/service_user_defaults.go (2 hunks)
- backend/internal/data/ent/client.go (11 hunks)
- backend/internal/data/ent/ent.go (2 hunks)
- backend/internal/data/ent/has_id.go (1 hunks)
- backend/internal/data/ent/hook/hook.go (1 hunks)
- backend/internal/data/ent/migrate/schema.go (3 hunks)
- backend/internal/data/ent/mutation.go (15 hunks)
- backend/internal/data/ent/oauth.go (1 hunks)
- backend/internal/data/ent/oauth/oauth.go (1 hunks)
- backend/internal/data/ent/oauth/where.go (1 hunks)
- backend/internal/data/ent/oauth_create.go (1 hunks)
- backend/internal/data/ent/oauth_delete.go (1 hunks)
- backend/internal/data/ent/oauth_query.go (1 hunks)
- backend/internal/data/ent/oauth_update.go (1 hunks)
- backend/internal/data/ent/predicate/predicate.go (1 hunks)
- backend/internal/data/ent/runtime.go (2 hunks)
- backend/internal/data/ent/schema/oauth.go (1 hunks)
- backend/internal/data/ent/schema/user.go (2 hunks)
- backend/internal/data/ent/tx.go (2 hunks)
- backend/internal/data/ent/user.go (3 hunks)
- backend/internal/data/ent/user/user.go (4 hunks)
- backend/internal/data/ent/user/where.go (2 hunks)
- backend/internal/data/ent/user_create.go (5 hunks)
- backend/internal/data/ent/user_query.go (8 hunks)
- backend/internal/data/ent/user_update.go (11 hunks)
- backend/internal/data/migrations/migrations/20240811221935_oidc.sql (1 hunks)
- backend/internal/data/repo/repo_group.go (1 hunks)
- backend/internal/data/repo/repo_oauth.go (1 hunks)
- backend/internal/data/repo/repo_users.go (1 hunks)
- backend/internal/data/repo/repos_all.go (2 hunks)
Files skipped from review due to trivial changes (3)
- backend/internal/data/ent/oauth/oauth.go
- backend/internal/data/ent/oauth_query.go
- backend/internal/data/repo/repo_users.go
Additional comments not posted (171)
backend/internal/data/ent/schema/oauth.go (5)
3-9: Imports are appropriate.The imported packages are essential for defining the schema and utilizing ent features.
15-19: Mixin usage is correct.The
BaseMixinis appropriately included, likely adding common fields or functionality.
21-27: Field definitions are sound.The fields
providerandsubare necessary for OAuth and correctly specified asNotEmpty.
30-35: Edge definition is accurate.The edge from
OAuthtoUseris correctly defined as unique, indicating a one-to-one relationship.
38-41: Index definition is appropriate.The index on
providerandsubfields ensures uniqueness and efficient querying.backend/internal/data/ent/has_id.go (1)
55-57: GetID method implementation is consistent.The
GetIDmethod forOAuthis correctly implemented, aligning with similar methods for other entities.backend/internal/data/repo/repos_all.go (2)
12-12: AllRepos struct modification is logical.The addition of the
OAuthfield enhances the repository's ability to manage OAuth operations.
27-27: New function update is consistent.The
OAuthfield is correctly initialized in the constructor, aligning with the initialization of other repositories.backend/internal/data/ent/predicate/predicate.go (1)
45-46: Addition of OAuth predicate type looks good.The introduction of the
OAuthpredicate type is consistent with the existing pattern and enhances query capabilities for OAuth-related operations.backend/internal/core/services/all.go (2)
11-11: Integration ofOAuthServiceintoAllServices.The addition of the
OAuthfield to theAllServicesstruct is a strategic enhancement, allowing for expanded service capabilities. This integration is well-aligned with the objective of supporting OIDC.
58-62: Verify the initialization ofOAuthService.The
OAuthServiceis initialized with dependencies onreposanduser. Ensure that these dependencies are correctly managed and that theOAuthServicefunctions as expected.Verification successful
Verification Complete: OAuthService Initialization and Usage
The
OAuthServiceis correctly initialized with its dependencies,reposanduser, and its methods are actively used across the codebase, ensuring proper functionality.
- Initialization: Verified in
backend/internal/core/services/all.go.- Method Usage: Methods such as
Login,ValidateCode,LoginWithIdToken,CreateUserIdToken, andCreateUserare utilized withinservice_oauth.goand other parts of the application, confirming their integration.The dependencies are managed correctly, and the service functions as expected. No issues found.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage and initialization of `OAuthService`. # Test: Search for the instantiation and usage of `OAuthService` in the codebase. Expect: Proper initialization and usage. rg --type go 'OAuthService'Length of output: 1326
Script:
#!/bin/bash # Description: Verify the usage of OAuthService methods in the codebase. # Test: Search for the usage of OAuthService methods in the codebase. rg --type go '(Login|ValidateCode|LoginWithIdToken|CreateUserIdToken|CreateUser)\('Length of output: 2205
backend/internal/data/migrations/migrations/20240811221935_oidc.sql (1)
1-18: SQL Migration for OIDC Support.The migration script effectively manages the creation of the
oauthstable and the modification of theuserstable. The use of foreign key constraints and indices aligns with best practices for data integrity and performance.backend/internal/data/ent/schema/user.go (2)
38-39: Optional Password Field inUserSchema.The
passwordfield is now optional, which is a logical adjustment to accommodate OAuth-based authentication. Ensure that this change is reflected in all relevant user creation and update processes.
63-66: Addition of OAuth Edge inUserSchema.The new edge to the
OAuthtype enhances the schema's capability to manage OAuth associations. This is a crucial step in supporting OIDC functionality.backend/app/api/providers/oauth.go (3)
16-20: StructOAuthProvideris well-defined.The struct encapsulates necessary components for OAuth operations effectively.
56-58: FunctionNameis correctly implemented.The function returns the provider's name as expected.
60-67: FunctionAuthenticateis correctly implemented.The function effectively handles authentication using the OAuth service.
backend/internal/data/ent/oauth_delete.go (1)
1-88: Generated fileoauth_delete.gois correctly implemented.The file follows standard patterns for deletion logic and error handling, consistent with
entgenerated code.backend/go.mod (4)
12-12: New OIDC Dependency Added:github.com/coreos/go-oidc/v3The addition of this dependency is crucial for implementing OpenID Connect functionality, which aligns with the PR objectives of enhancing authentication capabilities. Ensure that this library is compatible with the existing codebase and that any new features are thoroughly tested.
Verification successful
OIDC Package Integration Verified
The integration of
github.com/coreos/go-oidc/v3is confirmed across multiple files, indicating its role in enhancing authentication capabilities via OpenID Connect. The package is used effectively for creating providers, setting scopes, and verifying tokens, aligning with the project's objectives. No issues found with its usage in the codebase.
- Files with OIDC usage:
backend/app/api/providers/oauth.gobackend/internal/core/services/service_oauth.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify usage of the newly added `github.com/coreos/go-oidc/v3` package. # Test: Search for the usage of the `oidc` package. Expect: Relevant usage in the codebase. rg --type go 'oidc\.'Length of output: 625
28-28: Dependency Update:golang.org/x/cryptoThe update from
v0.23.0tov0.25.0may include important security patches and performance improvements. Verify that the changes in this package do not introduce breaking changes or require modifications in the existing code.Verification successful
Dependency Update:
golang.org/x/cryptoThe update from
v0.23.0tov0.25.0appears to have no direct impact on the current codebase, as there are no direct imports or usage ofgolang.org/x/cryptodetected. However, I recommend verifying any indirect dependencies that might utilize this package. Proceed with caution and ensure thorough testing.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `golang.org/x/crypto` update. # Test: Check for any breaking changes or deprecated functions used in the codebase. rg --type go 'crypto\.'Length of output: 25
Script:
#!/bin/bash # Description: Search for imports of `golang.org/x/crypto` in the Go codebase. rg --type go 'import\s+"golang.org/x/crypto'Length of output: 46
42-42: New JWT Dependency Added:github.com/go-jose/go-jose/v4This addition likely supports JSON Web Token operations, which are integral to OIDC implementations. Ensure that JWT handling is secure and aligns with best practices.
71-72: Dependency Updates:golang.org/x/netandgolang.org/x/sysBoth packages have been updated, potentially bringing improvements and bug fixes. Ensure that these updates do not conflict with existing network or system operations within the application.
backend/internal/core/services/service_oauth.go (1)
68-93: VerifyLoginWithIdTokenLogicThe method checks if the
Verifieris nil and handles the ID token. Ensure that the logic for creating a new user when not found is robust and secure. Consider logging the creation process for better traceability.backend/internal/data/ent/oauth.go (1)
160-178: ConfirmStringMethod ImplementationThe
Stringmethod provides a string representation of the OAuth entity. Ensure that sensitive information is not inadvertently exposed in logs or error messages.backend/internal/core/services/service_user.go (1)
99-101: Refactored Label Creation: EnsurecreateDefaultLabelsis robust.The refactoring of label creation into
createDefaultLabelsenhances readability. However, ensure that this function handles all edge cases and errors gracefully.Verification successful
Functionality Confirmed:
createDefaultLabelsHandles Errors AppropriatelyThe
createDefaultLabelsfunction inservice_user_defaults.gologs the process and handles errors during label creation. Ensure thatdefaultLabels()provides valid data and that the repository'sCreatemethod is resilient to unexpected input or failures.
- File:
backend/internal/core/services/service_user_defaults.go- Function:
createDefaultLabelsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the implementation of `createDefaultLabels`. # Test: Locate the function definition and review its logic. ast-grep --lang go --pattern $'func createDefaultLabels(ctx context.Context, repos *repo.AllRepos, groupID uuid.UUID) error { $$$ }'Length of output: 135
Script:
#!/bin/bash # Description: Search for the `createDefaultLabels` function definition in the Go codebase. # Test: Locate any function named `createDefaultLabels`. rg 'func createDefaultLabels' --type go -A 5Length of output: 647
backend/internal/data/ent/tx.go (2)
186-186: Initialization Enhancement: Confirm OAuth Client Setup.The
initmethod now includes the initialization of theOAuthclient. Confirm that this setup is consistent with other client initializations and that it doesn't introduce side effects.
39-40: OAuth Client Integration: Verify Initialization Logic.The addition of the
OAuthclient to theTxstruct is a strategic enhancement. Ensure thatNewOAuthClientis correctly implemented and handles configuration nuances.Verification successful
Ah, it seems our initial probe didn't return the expected results. Let's widen our search parameters to ensure we capture any variations or related implementations of the
OAuthClient. Allow me to run another diagnostic sweep.
OAuth Client Initialization Confirmed.
The
NewOAuthClientfunction has been successfully located and verified. It is implemented inbackend/internal/data/ent/client.goat line 2447. Ensure that this function is properly invoked during theTxstruct initialization to maintain seamless OAuth interactions.
- File:
backend/internal/data/ent/client.go- Line: 2447
Integration appears sound, but always wise to verify any configuration nuances. Proceed with confidence, and may your code be ever robust.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the implementation of `NewOAuthClient`. # Test: Locate the function definition and review its logic. ast-grep --lang go --pattern $'func NewOAuthClient(config Config) *OAuthClient { $$$ }'Length of output: 90
Script:
#!/bin/bash # Description: Search for any functions related to OAuthClient in the codebase. # Test: Locate any function definitions that return an *OAuthClient. ast-grep --lang go --pattern $'func $_($$$) *OAuthClient { $$$ }'Length of output: 270
backend/internal/data/repo/repo_group.go (1)
280-282: New MethodGroupByName: Validate Query Logic.The
GroupByNamemethod enhances the repository's querying capabilities. Ensure the query logic is efficient and correctly maps the result.backend/app/api/routes.go (2)
71-71: RenamingproviderstoproviderListenhances clarity.The new name better reflects the purpose as a list of authentication providers.
83-83: Ensure all references toprovidersare updated toproviderList.The change to
providerListshould be consistent across all usages to avoid potential errors.Verification successful
The change to
providerListis correctly applied. Theproviderspackage and the local variableprovidersinv1_ctrl_auth.goserve different purposes and should remain unchanged. The update toproviderListinroutes.gois appropriate for managing the list of authentication providers. No further changes are necessary.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `providers` are updated to `providerList`. # Test: Search for occurrences of `providers`. Expect: No occurrences. rg --type go 'providers'Length of output: 947
Script:
#!/bin/bash # Investigate the context of `providers` usage in `routes.go` and `v1_ctrl_auth.go`. # Show surrounding lines for occurrences in routes.go rg --type go -A 5 -B 5 'providers' backend/app/api/routes.go # Show surrounding lines for occurrences in v1_ctrl_auth.go rg --type go -A 5 -B 5 'providers' backend/app/api/handlers/v1/v1_ctrl_auth.goLength of output: 1915
backend/internal/data/ent/user.go (3)
55-59: Integration of OAuth data intoUserEdgesis well-structured.The addition of the
Oauthfield and the expansion ofloadedTypesare consistent and enhance the model's capabilities.
93-100:OauthOrErrmethod follows established patterns effectively.The method provides a consistent approach to handling OAuth data retrieval with error checking.
227-230:QueryOauthmethod enhances OAuth querying capabilities.The method aligns with existing query patterns and improves the model's functionality.
backend/internal/data/ent/user/user.go (4)
43-44: Addition of OAuth-related constants is essential and well-structured.The constants are necessary for integrating OAuth functionality within the user management system.
Also applies to: 68-74
247-252:ByOauthCountfunction adds valuable querying capabilities.The function enhances the ability to order user data based on OAuth interactions.
254-259:ByOauthfunction aligns with existing patterns and enhances functionality.The function allows for ordering based on specific OAuth terms, improving querying capabilities.
281-287:newOauthStepfunction is crucial for OAuth integration.The function facilitates the creation of SQL graph steps for OAuth relationships, essential for the new functionality.
backend/internal/data/ent/oauth_create.go (10)
25-29: Functionality Verified: SetCreatedAtThe method correctly sets the "created_at" field using the mutation object. Well done.
31-37: Functionality Verified: SetNillableCreatedAtThe method appropriately checks for nil values before setting the "created_at" field. Good job.
39-43: Functionality Verified: SetUpdatedAtThe method correctly sets the "updated_at" field using the mutation object. Well done.
45-51: Functionality Verified: SetNillableUpdatedAtThe method appropriately checks for nil values before setting the "updated_at" field. Good job.
53-57: Functionality Verified: SetProviderThe method correctly sets the "provider" field using the mutation object. Well done.
59-63: Functionality Verified: SetSubThe method correctly sets the "sub" field using the mutation object. Well done.
103-107: Functionality Verified: SaveThe method effectively saves the OAuth entity, applying defaults and hooks as expected. Excellent implementation.
147-171: Validation Confirmed: checkThe method performs necessary validation checks on required fields, ensuring data integrity. Great work.
174-194: SQL Operation Verified: sqlSaveThe method handles SQL save operations with proper error handling for constraint violations. Well executed.
197-239: Specification Creation Verified: createSpecThe method constructs the SQL graph specification accurately, ensuring proper entity definition. Excellent work.
backend/internal/data/ent/hook/hook.go (1)
160-166: Mutation Method Confirmed: OAuthFunc.MutateThe method properly checks the mutation type and executes the function, with error handling for unexpected types. Well implemented.
backend/internal/data/ent/oauth/where.go (7)
14-57: ID Predicate Functions VerifiedThe ID predicate functions are correctly implemented for various query operations. Well done.
59-117: CreatedAt Predicate Functions VerifiedThe CreatedAt predicate functions are correctly implemented for various query operations. Excellent implementation.
119-157: UpdatedAt Predicate Functions VerifiedThe UpdatedAt predicate functions are correctly implemented for various query operations. Great work.
159-222: Provider Predicate Functions VerifiedThe Provider predicate functions are correctly implemented for various query operations. Well executed.
224-287: Sub Predicate Functions VerifiedThe Sub predicate functions are correctly implemented for various query operations. Excellent job.
289-310: User Edge Predicate Functions VerifiedThe User edge predicate functions are correctly implemented for edge-based query operations. Well done.
312-325: Logical Predicate Functions VerifiedThe logical predicate functions are correctly implemented for combining predicates. Excellent work.
backend/internal/data/ent/oauth_update.go (6)
1-2: Generated Code Notice.This file is generated by Ent. Manual edits may be overwritten.
33-37: Ensure Correctness ofSetUpdatedAt.The
SetUpdatedAtmethod correctly updates theupdated_atfield. Ensure that the timestamp provided is accurate and consistent across the application.
133-146: Validation Logic Confirmation.The
checkmethod validates fields using external validators. Ensure these validators are comprehensive and cover all edge cases.
148-208: SQL Update Logic Review.The
sqlSavemethod constructs and executes the SQL update operation. The logic appears sound, but ensure that all predicates and edge cases are handled correctly.
39-43: VerifySetProviderLogic.The
SetProvidermethod sets the provider field. Ensure that the provider string is validated elsewhere to prevent invalid entries.Verification successful
Validation of
SetProviderLogic Confirmed. TheSetProvidermethod is safeguarded by aProviderValidatorfunction, ensuring that the provider string is validated before any save operation. This effectively prevents invalid entries. No further action is required.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `SetProvider` method is used with valid provider strings. # Test: Search for `SetProvider` usage. Expect: Validation logic in place. rg --type go 'SetProvider'Length of output: 1225
Script:
#!/bin/bash # Search for validation logic related to the provider field in OAuthUpdate and related classes. rg --type go 'provider' -A 10Length of output: 38421
125-131: Check Default Value Logic forUpdatedAt.The
defaultsmethod ensuresUpdatedAtis set if not provided. Verify thatoauth.UpdateDefaultUpdatedAt()returns a sensible default.Verification successful
Default Value Logic for
UpdatedAtVerifiedThe
UpdateDefaultUpdatedAtfunction is set up to return a sensible default value, likely the current time, through a schema descriptor in theruntime.gofile. This setup is typical for timestamp fields. No further action is needed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the default value logic for `UpdatedAt`. # Test: Search for `UpdateDefaultUpdatedAt` function. Expect: Sensible default value. ast-grep --lang go --pattern 'func UpdateDefaultUpdatedAt() time.Time { $$$ }'Length of output: 80
Script:
#!/bin/bash # Use ripgrep to search for the definition of the UpdateDefaultUpdatedAt function. rg 'func UpdateDefaultUpdatedAt' --context 5Length of output: 46
Script:
#!/bin/bash # Use ripgrep to search for any function related to UpdatedAt. rg 'UpdatedAt' --context 5Length of output: 434941
Script:
#!/bin/bash # Use ripgrep to search for the implementation details of the UpdateDefaultUpdatedAt function. rg 'func UpdateDefaultUpdatedAt' -A 10Length of output: 40
Script:
#!/bin/bash # Search for assignments or initializations of the UpdateDefaultUpdatedAt variable. rg 'UpdateDefaultUpdatedAt\s*=\s*' -A 5Length of output: 8539
backend/internal/data/ent/user_create.go (2)
435-450: Check OAuth Edge Construction.The
createSpecmethod constructs edges for OAuth relationships. Ensure that these edges are correctly defined and that the relationships are valid.
74-80: ReviewSetNillablePasswordMethod.The
SetNillablePasswordmethod allows optional password setting. Ensure that this aligns with security policies and does not inadvertently allow empty passwords.backend/internal/data/ent/ent.go (2)
27-27: OAuth Package Integration.The inclusion of the OAuth package signifies expanded functionality. Ensure that all OAuth-related logic is correctly integrated and tested.
101-101: Validateoauth.TableMapping.The addition of
oauth.Tableto the column check mapping ensures OAuth table validation. Confirm that this does not conflict with existing validation logic.backend/internal/data/ent/user/where.go (4)
364-367: Functionality Approved: PasswordIsNilThe implementation for checking if the password is nil is correct and consistent with existing patterns. Well done.
369-372: Functionality Approved: PasswordNotNilThe implementation for checking if the password is not nil is correct and consistent with existing patterns. Well executed.
543-552: Functionality Approved: HasOauthThe implementation for checking the existence of related OAuth records is correct and consistent with existing patterns. Good job.
554-564: Functionality Approved: HasOauthWithThe implementation for checking related OAuth records with additional predicates is correct and consistent with existing patterns. Excellent work.
backend/internal/data/ent/migrate/schema.go (3)
401-409: Schema Approved: OauthsColumnsThe columns for the "oauths" table are well-defined, providing necessary fields for OAuth data management. The nullable
user_oauthcolumn is a thoughtful addition for flexibility.
411-430: Schema Approved: OauthsTableThe "oauths" table is well-structured, with a primary key, foreign key, and an index for efficient querying. Excellent design for managing OAuth relationships.
430-438: Schema Modification Approved: UsersColumnsThe modification to make the password field nullable is a logical step towards supporting OAuth-authenticated users without passwords. Well-considered change.
backend/internal/data/ent/user_query.go (4)
33-33: Field Addition Approved: withOauthThe addition of the
withOauthfield inUserQueryaligns with existing patterns and supports OAuth querying effectively.
137-157: Method Approved: QueryOauthThe
QueryOauthmethod is well-implemented, enabling effective chaining of queries on the "oauth" edge. This enhances the query capabilities for OAuth data.
394-403: Method Approved: WithOauthThe
WithOauthmethod is well-implemented, allowing for eager loading of OAuth nodes with optional configurations. This adds significant flexibility to OAuth queries.
638-668: Function Approved: loadOauthThe
loadOauthfunction is well-implemented, ensuring correct loading and assignment of OAuth relationships. This function is crucial for managing OAuth data effectively.backend/internal/data/ent/mutation.go (77)
27-27: Import Addition Approved.The addition of the
oauthpackage import is necessary for the new OAuth functionalities.
53-53: Type Declaration Approved.The introduction of the
TypeOAuthconstant is appropriate for identifying OAuth entities.
10675-10690: Struct Definition Approved.The
OAuthMutationstruct is well-structured, encapsulating necessary fields for OAuth operations. Ensure thorough testing of its methods.
10698-10709: Function Implementation Approved.The
newOAuthMutationfunction correctly initializes anOAuthMutationand applies provided options.
10712-10730: Function Implementation Approved.The
withOAuthIDfunction correctly sets the ID and defines a mechanism to retrieve old values.
10734-10740: Function Implementation Approved.The
withOAuthfunction correctly sets the old OAuth node for the mutation.
10745-10749: Function Implementation Approved.The
Clientfunction correctly initializes and returns a newent.Client.
10753-10760: Function Implementation Approved.The
Txfunction correctly returns a transactional client if applicable.
10764-10766: Function Implementation Approved.The
SetIDfunction correctly sets the ID for the mutation.
10770-10775: Function Implementation Approved.The
IDfunction correctly returns the ID value if it exists.
10781-10794: Function Implementation Approved.The
IDsfunction correctly queries the database for entity IDs based on the mutation's predicate.
10797-10799: Function Implementation Approved.The
SetCreatedAtfunction correctly sets the "created_at" field.
10802-10808: Function Implementation Approved.The
CreatedAtfunction correctly returns the value of the "created_at" field if it exists.
10813-10825: Function Implementation Approved.The
OldCreatedAtfunction correctly retrieves the old "created_at" value, handling errors appropriately.
10828-10830: Function Implementation Approved.The
ResetCreatedAtfunction correctly resets changes to the "created_at" field.
10833-10835: Function Implementation Approved.The
SetUpdatedAtfunction correctly sets the "updated_at" field.
10838-10844: Function Implementation Approved.The
UpdatedAtfunction correctly returns the value of the "updated_at" field if it exists.
10849-10861: Function Implementation Approved.The
OldUpdatedAtfunction correctly retrieves the old "updated_at" value, handling errors appropriately.
10864-10866: Function Implementation Approved.The
ResetUpdatedAtfunction correctly resets changes to the "updated_at" field.
10869-10871: Function Implementation Approved.The
SetProviderfunction correctly sets the "provider" field.
10874-10880: Function Implementation Approved.The
Providerfunction correctly returns the value of the "provider" field if it exists.
10885-10897: Function Implementation Approved.The
OldProviderfunction correctly retrieves the old "provider" value, handling errors appropriately.
10900-10902: Function Implementation Approved.The
ResetProviderfunction correctly resets changes to the "provider" field.
10905-10907: Function Implementation Approved.The
SetSubfunction correctly sets the "sub" field.
10910-10916: Function Implementation Approved.The
Subfunction correctly returns the value of the "sub" field if it exists.
10921-10933: Function Implementation Approved.The
OldSubfunction correctly retrieves the old "sub" value, handling errors appropriately.
10936-10938: Function Implementation Approved.The
ResetSubfunction correctly resets changes to the "sub" field.
10941-10943: Function Implementation Approved.The
SetUserIDfunction correctly sets the "user" edge to the User entity by id.
10946-10948: Function Implementation Approved.The
ClearUserfunction correctly clears the "user" edge to the User entity.
10951-10953: Function Implementation Approved.The
UserClearedfunction correctly reports if the "user" edge was cleared.
10956-10961: Function Implementation Approved.The
UserIDfunction correctly returns the "user" edge ID if it exists.
10966-10971: Function Implementation Approved.The
UserIDsfunction correctly returns the "user" edge IDs for internal use.
10974-10977: Function Implementation Approved.The
ResetUserfunction correctly resets changes to the "user" edge.
10980-10982: Function Implementation Approved.The
Wherefunction correctly appends predicates to the OAuthMutation builder.
10986-10992: Function Implementation Approved.The
WherePfunction correctly appends storage-level predicates to the OAuthMutation builder.
10995-10997: Function Implementation Approved.The
Opfunction correctly returns the operation type.
11000-11002: Function Implementation Approved.The
SetOpfunction correctly sets the mutation operation.
11005-11007: Function Implementation Approved.The
Typefunction correctly returns the node type of the mutation.
11012-11027: Function Implementation Approved.The
Fieldsfunction correctly returns all fields that were changed during the mutation.
11032-11044: Function Implementation Approved.The
Fieldfunction correctly returns the value of a field with the given name if it exists.
11049-11061: Function Implementation Approved.The
OldFieldfunction correctly retrieves the old value of the field, handling errors appropriately.
11066-11098: Function Implementation Approved.The
SetFieldfunction correctly sets the value of a field, handling type mismatches appropriately.
11102-11104: Function Implementation Approved.The
AddedFieldsfunction correctly returns an empty slice as no numeric fields are handled.
11109-11111: Function Implementation Approved.The
AddedFieldfunction correctly returns nil as no numeric fields are handled.
11116-11120: Function Implementation Approved.The
AddFieldfunction correctly handles unknown fields by returning an error.
11124-11126: Function Implementation Approved.The
ClearedFieldsfunction correctly returns an empty slice as no nullable fields are handled.
11130-11133: Function Implementation Approved.The
FieldClearedfunction correctly checks if a field was cleared in the mutation.
11137-11139: Function Implementation Approved.The
ClearFieldfunction correctly handles unknown fields by returning an error.
11143-11159: Function Implementation Approved.The
ResetFieldfunction correctly resets known fields and handles unknown fields by returning an error.
11162-11168: Function Implementation Approved.The
AddedEdgesfunction correctly returns all edge names that were set/added in the mutation.
11172-11180: Function Implementation Approved.The
AddedIDsfunction correctly retrieves added IDs for known edges.
11183-11186: Function Implementation Approved.The
RemovedEdgesfunction correctly returns an empty slice as no edges are removed.
11190-11192: Function Implementation Approved.The
RemovedIDsfunction correctly returns nil as no IDs are removed.
11195-11201: Function Implementation Approved.The
ClearedEdgesfunction correctly returns all edge names that were cleared in the mutation.
11205-11211: Function Implementation Approved.The
EdgeClearedfunction correctly checks if an edge was cleared in the mutation.
11215-11222: Function Implementation Approved.The
ClearEdgefunction correctly clears known edges and handles unknown edges by returning an error.
11226-11233: Function Implementation Approved.The
ResetEdgefunction correctly resets known edges and handles unknown edges by returning an error.
11259-11261: Struct Modifications Approved.The modifications to
UserMutationcorrectly incorporate OAuth-related fields, enhancing its capabilities.
11547-11550: Function Implementation Approved.The
ClearPasswordfunction correctly clears the "password" field.
11553-11556: Function Implementation Approved.The
PasswordClearedfunction correctly checks if the "password" field was cleared.
11561-11563: Function Implementation Approved.The
ResetPasswordfunction correctly resets all changes to the "password" field.
11869-11876: Function Implementation Approved.The
AddOauthIDsfunction correctly adds the "oauth" edge to the OAuth entity by IDs.
11879-11881: Function Implementation Approved.The
ClearOauthfunction correctly clears the "oauth" edge to the OAuth entity.
11884-11886: Function Implementation Approved.The
OauthClearedfunction correctly reports if the "oauth" edge was cleared.
11889-11897: Function Implementation Approved.The
RemoveOauthIDsfunction correctly removes the "oauth" edge to the OAuth entity by IDs.
11900-11905: Function Implementation Approved.The
RemovedOauthIDsfunction correctly returns the removed IDs of the "oauth" edge to the OAuth entity.
11908-11913: Function Implementation Approved.The
OauthIDsfunction correctly returns the "oauth" edge IDs in the mutation.
11916-11920: Function Implementation Approved.The
ResetOauthfunction correctly resets all changes to the "oauth" edge.
12139-12141: Function Implementation Approved.The
ClearedFieldsfunction correctly returns all fields that were cleared during the mutation.
12159-12161: Function Implementation Approved.The
ClearFieldfunction correctly clears known fields and handles unknown fields by returning an error.
Line range hint
12206-12218:
Function Implementation Approved.The
AddedEdgesfunction correctly returns all edge names that were set/added in the mutation.
12243-12247: Function Implementation Approved.The
AddedIDsfunction correctly retrieves added IDs for known edges.
12254-12263: Function Implementation Approved.The
RemovedEdgesfunction correctly returns all edge names that were removed in the mutation.
12284-12288: Function Implementation Approved.The
RemovedIDsfunction correctly retrieves removed IDs for known edges.
Line range hint
12295-12307:
Function Implementation Approved.The
ClearedEdgesfunction correctly returns all edge names that were cleared in the mutation.
12321-12322: Function Implementation Approved.The
EdgeClearedfunction correctly checks if an edge was cleared in the mutation.
12351-12353: Function Implementation Approved.The
ResetEdgefunction correctly resets known edges and handles unknown edges by returning an error.backend/internal/data/ent/user_update.go (12)
193-197: MethodAddOauthIDsis functioning optimally.The method efficiently adds OAuth IDs to the user mutation, ensuring seamless integration with the existing logic. Well executed.
199-206: MethodAddOauthis operating as intended.The conversion of OAuth objects to IDs is handled with precision, and the subsequent addition to the mutation is flawless. Excellent work.
261-265: MethodClearOauthperforms admirably.The clearing of OAuth edges is executed with precision, ensuring a clean slate for OAuth relationships. Well done.
267-271: MethodRemoveOauthIDsis executed flawlessly.The targeted removal of OAuth IDs is precise and integrates seamlessly with the mutation logic. Excellent implementation.
273-280: MethodRemoveOauthis functioning optimally.The conversion of OAuth objects to IDs and their subsequent removal is handled with precision. Well executed.
507-551: Mutation logic for OAuth is integrated seamlessly.The handling of OAuth relationships during save operations is precise and robust, ensuring data integrity. Excellent work.
729-733: MethodAddOauthIDsinUserUpdateOneis functioning optimally.The addition of OAuth IDs to a single user mutation is executed with precision. Well done.
735-742: MethodAddOauthinUserUpdateOneis operating as intended.The conversion of OAuth objects to IDs and their addition to the mutation is flawless. Excellent implementation.
797-801: MethodClearOauthinUserUpdateOneperforms admirably.The clearing of OAuth edges is executed with precision, ensuring a clean slate for OAuth relationships. Well done.
803-807: MethodRemoveOauthIDsinUserUpdateOneis executed flawlessly.The targeted removal of OAuth IDs is precise and integrates seamlessly with the mutation logic. Excellent implementation.
809-816: MethodRemoveOauthinUserUpdateOneis functioning optimally.The conversion of OAuth objects to IDs and their subsequent removal is handled with precision. Well executed.
1073-1117: Mutation logic for OAuth inUserUpdateOneis integrated seamlessly.The handling of OAuth relationships during save operations is precise and robust, ensuring data integrity. Excellent work.
backend/internal/data/ent/runtime.go (6)
20-20: OAuth package imported successfully.The integration of the OAuth package into the data structure is executed flawlessly. Well done.
553-574: Default values for OAuth schema fields are correctly assigned.The default values for
created_at,updated_at, andidfields are set with precision, ensuring consistent data initialization. Excellent work.
563-566: Provider field validator is correctly implemented.The validator for the
providerfield ensures data integrity with precision. Well executed.
567-570: Sub field validator is correctly implemented.The validator for the
subfield ensures data integrity with precision. Well executed.
571-574: Default ID value for OAuth schema is correctly assigned.The default value for the
idfield is set with precision, ensuring consistent data initialization. Excellent work.
548-574: OAuth schema integration into runtime configuration is seamless.The integration aligns perfectly with the application's schema requirements, enhancing functionality with precision. Well done.
Comments failed to post (10)
backend/internal/core/services/service_user_defaults.go
62-79: Enhance error handling and logging.
The
createDefaultLabelsfunction could benefit from more detailed error handling and logging. Consider logging the specific label or location that caused an error to improve traceability. Additionally, consider wrapping errors with additional context using a package likefmt.Errorf.if err != nil { log.Error().Err(err).Msgf("failed to create label: %v", label) return fmt.Errorf("failed to create label %s: %w", label.Name, err) }Similarly, apply this pattern to the locations creation loop.
backend/internal/data/repo/repo_oauth.go
62-62: Address the TODO comment.
The TODO comment indicates that the functionality for deleting connections and checking for existing connections is incomplete. Consider implementing this logic or tracking it in a dedicated issue to ensure it is not overlooked.
Would you like me to draft the logic for this functionality or open a GitHub issue to track it?
28-40: Enhance error handling in
GetUserFromToken.Consider providing more context in the error returned by
GetUserFromTokento improve debugging. For example, you could wrap the error with additional information about the provider and subject.if err != nil { return UserOut{}, fmt.Errorf("failed to get user for provider %s and subject %s: %w", provider, sub, err) }
42-60: Improve error handling in
Create.Enhance the error handling in the
Createmethod by wrapping the error with context about the operation being performed. This will aid in debugging and understanding the source of the error.if err != nil { return OAuth{}, fmt.Errorf("failed to create OAuth entry for provider %s and subject %s: %w", create.Provider, create.Subject, err) }backend/app/api/providers/oauth.go
22-54: Consider implementing fallback logic for environment variables.
The TODO comment indicates missing fallback mechanisms for environment variables if no well-known URL is supported. This could enhance robustness.
// Example fallback logic if clientId == "" || clientSecret == "" || redirectUri == "" { // Implement fallback or default configurations }backend/app/api/routes.go
74-79: Consider improving error handling for OAuth provider creation.
Using
panicfor error handling is not recommended in production code as it can crash the application. Consider logging the error and failing gracefully.if err != nil { log.Printf("Error creating OAuth provider: %v", err) return }backend/internal/core/services/service_oauth.go
43-49: Ensure Proper Error Handling in
LoginMethodThe
Loginmethod relies onValidateCodefor user authentication. Ensure that any errors returned are logged appropriately to aid in debugging and monitoring. Consider adding more detailed logging for failure scenarios.if err != nil { log.Err(err).Msg("Failed to validate code during login") return UserAuthTokenDetail{}, ErrorInvalidLogin }
52-66: Improve Error Handling in
ValidateCodeMethodThe current implementation uses a panic statement, which is not ideal for handling errors gracefully. Consider implementing a fallback mechanism or a more informative error message.
if !ok { log.Warn().Msg("ID token verification failed; consider fallback to user info") // Implement fallback logic here return repo.UserOut{}, errors.New("ID token verification failed") }
95-118: Security Consideration in
CreateUserIdTokenEnsure that the email verification status is checked before creating a user. This prevents the creation of accounts with unverified emails, enhancing security.
if !claims.EmailVerified { return repo.UserOut{}, errors.New("email not verified") }backend/internal/data/ent/oauth.go
79-129: Ensure Type Safety in
assignValuesMethodThe method assigns values from SQL rows to the OAuth fields. Ensure that all type assertions are safe and consider logging any type mismatches for easier debugging.
if value, ok := values[i].(*uuid.UUID); !ok { log.Err(fmt.Errorf("unexpected type %T for field id", values[i])).Msg("Type assertion failed") return fmt.Errorf("unexpected type %T for field id", values[i]) }
Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (Dutch) Currently translated at 91.0% (81 of 89 strings) Translated using Weblate (Dutch) Currently translated at 91.0% (81 of 89 strings) Co-authored-by: 101br03k <warmerdamm03@gmail.com> Co-authored-by: Andreas Olsson <basen82@icloud.com> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: Weblate Translation Memory <noreply-mt-weblate-translation-memory@weblate.org> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/nl/ Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/sv/ Translation: Homebox/Frontend
Co-authored-by: SKNTim <timmy444074@gmail.com>
Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (Dutch) Currently translated at 94.3% (84 of 89 strings) Translated using Weblate (Dutch) Currently translated at 94.3% (84 of 89 strings) Co-authored-by: 101br03k <warmerdamm03@gmail.com> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: SKNTim <timmy444074@gmail.com> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/nl/ Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/zh_Hant/ Translation: Homebox/Frontend
katosdev
added
⬆️ enhancement
|
In regards to Azure AD/Google Workspaces OIDC the commit on this project shows some of the things that had to be adjusted to make those work: documenso/documenso@70eeb1a It's a different project and a different language, but it should be fairly easy to port anything needed to Go/VueJS |
…minsmedia#170) * Update it.json Translate all strings into italian and reorder alphabetically * Update de.json Translated all strings into German and sorted them alphabetically. * Update it.json Added missing commas * Update it.json Fix indentation and remove unnecessary curly bracket left behind during the translation * Replace 'Edit', 'Create', and 'Other' with their Italian equivalents * Replace 'Edit', 'Create', and 'Other' with their German equivalents
Currently translated at 77.5% (69 of 89 strings) Translated using Weblate (French) Currently translated at 77.5% (69 of 89 strings) Translated using Weblate (French) Currently translated at 77.5% (69 of 89 strings) Translated using Weblate (Dutch) Currently translated at 96.6% (86 of 89 strings) Co-authored-by: Julien <hydreliox@gmail.com> Co-authored-by: Matthew Kilgore <matthew@kilgore.dev> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: Weblate Translation Memory <noreply-mt-weblate-translation-memory@weblate.org> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/fr/ Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/nl/ Translation: Homebox/Frontend
Currently translated at 88.7% (79 of 89 strings) Translated using Weblate (French) Currently translated at 88.7% (79 of 89 strings) Co-authored-by: Julien <hydreliox@gmail.com> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/fr/ Translation: Homebox/Frontend
Co-authored-by: Slydite4 <39199098+Slydite4@users.noreply.github.com>
Currently translated at 51.6% (46 of 89 strings) Translated using Weblate (Spanish) Currently translated at 51.6% (46 of 89 strings) Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: Slydite4 <39199098+Slydite4@users.noreply.github.com> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/es/ Translation: Homebox/Frontend
Currently translated at 56.1% (50 of 89 strings) Translated using Weblate (Spanish) Currently translated at 56.1% (50 of 89 strings) Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: Slydite4 <39199098+Slydite4@users.noreply.github.com> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/es/ Translation: Homebox/Frontend
Currently translated at 58.4% (52 of 89 strings) Translated using Weblate (Spanish) Currently translated at 58.4% (52 of 89 strings) Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: Slydite4 <39199098+Slydite4@users.noreply.github.com> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/es/ Translation: Homebox/Frontend
Currently translated at 60.6% (54 of 89 strings) Translated using Weblate (Spanish) Currently translated at 60.6% (54 of 89 strings) Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: Slydite4 <39199098+Slydite4@users.noreply.github.com> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/es/ Translation: Homebox/Frontend
Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (89 of 89 strings) Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: Slydite4 <39199098+Slydite4@users.noreply.github.com> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/es/ Translation: Homebox/Frontend
Co-authored-by: Fedor M <k930bx@gmail.com>
Currently translated at 25.8% (23 of 89 strings) Translated using Weblate (Russian) Currently translated at 25.8% (23 of 89 strings) Co-authored-by: Fedor M <k930bx@gmail.com> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/ru/ Translation: Homebox/Frontend
Currently translated at 33.7% (30 of 89 strings) Translated using Weblate (Russian) Currently translated at 33.7% (30 of 89 strings) Co-authored-by: Fedor M <k930bx@gmail.com> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/ru/ Translation: Homebox/Frontend
Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (Russian) Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (Turkish) Currently translated at 57.3% (51 of 89 strings) Co-authored-by: Fedor M <k930bx@gmail.com> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/ru/ Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/tr/ Translation: Homebox/Frontend
Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (German) Currently translated at 100.0% (89 of 89 strings) Co-authored-by: Dominik <account@kowanda.net> Co-authored-by: Fedor M <k930bx@gmail.com> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/de/ Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/ru/ Translation: Homebox/Frontend
|
Thanks for your PR @kloenk and apologies for the delays on this one. I have a few comments to add:
|
|
Just a thought on the Secure Cookies thing, some users may not proxy their HomeLab, while I would normally agree, that might cause issues? Maybe it should be something that can be set in the config/environment? |
* chore: update links * feat: update social link
Currently translated at 65.2% (92 of 141 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 65.2% (92 of 141 strings) Translated using Weblate (German) Currently translated at 73.7% (104 of 141 strings) Translated using Weblate (German) Currently translated at 73.7% (104 of 141 strings) Translated using Weblate (German) Currently translated at 73.7% (104 of 141 strings) Translated using Weblate (English) Currently translated at 100.0% (141 of 141 strings) Co-authored-by: Matthew Kilgore <matthew@kilgore.dev> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: Sascha Brockel <gsydaydreamer@gmail.com> Co-authored-by: dongzh <whitefivefiveopen@gmail.com> Co-authored-by: hirnchirurg <wilhelm.humerez@posteo.de> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/de/ Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/en/ Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/zh_Hans/ Translation: Homebox/Frontend
Currently translated at 79.4% (112 of 141 strings) Translated using Weblate (German) Currently translated at 79.4% (112 of 141 strings) Translated using Weblate (German) Currently translated at 79.4% (112 of 141 strings) Translated using Weblate (German) Currently translated at 79.4% (112 of 141 strings) Co-authored-by: Mats <sysadminsmedia@mats-bueser.de> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Co-authored-by: Nic <nicmeier1@gmx.net> Co-authored-by: Sascha Brockel <gsydaydreamer@gmail.com> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/de/ Translation: Homebox/Frontend
Currently translated at 68.0% (96 of 141 strings) Translated using Weblate (French) Currently translated at 68.0% (96 of 141 strings) Co-authored-by: Jean-Philippe Baril <translate.sysadminsmedia.com@alias.trebaxis.net> Co-authored-by: MyMemory <noreply-mt-mymemory@weblate.org> Translate-URL: https://translate.sysadminsmedia.com/projects/homebox/frontend/fr/ Translation: Homebox/Frontend
Have been thinking about this myself, I think an environment variable is the way forward. Can then do the same for allowed hosts instead of allowing open redirects too |
Update Documentation: Quick Start
…ble-headers-customisable make ItemViewTable headers customisable
|
Hey! Sorry @kloenk for the delays on this one. |
# Conflicts: # backend/go.mod # backend/go.sum # frontend/pages/index.vue # frontend/pages/profile.vue # frontend/plugins/i18n.ts
frontend/pages/index.vue
Outdated
| @@ -230,28 +258,33 @@ | |||
| </div> | |||
| </form> | |||
| </Transition> | |||
| <div class="mt-6 text-center"> | |||
| <a | |||
| href="https://auth.kloenk.dev/realms/kloenk/protocol/openid-connect/auth?client_id=homebox-dev&redirect_uri=http%3A%2F%2Flocalhost%3A3000%2Fauth%2Foidc%2Fcallback&response_type=code&scope=openid+email+profile&response_mode=query" | |||
There was a problem hiding this comment.
This should not be hardcoded? We need to make sure that this is configurable.
What type of PR is this?
What this PR does / why we need it:
Implement OIDC login feature
Which issue(s) this PR fixes:
Fixes #6
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
Documentation
Chores